Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bump] to NLog version 5.2.7 #286

Closed
wants to merge 3 commits into from
Closed

[Bump] to NLog version 5.2.7 #286

wants to merge 3 commits into from

Conversation

samatstariongroup
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

  • [Bump] to NLog version 5.2.7
  • Update test dependencies
  • update netcore test projects to net8.0
  • Set up JDK 17 in GitHub action to satisfy SonarSource requirments

samatrhea added 2 commits December 7, 2023 10:31
[Bump] NLog to 5.2.7
573dff7 
[Bump] test dependencies
[Bump] tests to net8.0
61aca2c 
[Update] GitHub Actions to net8.0 and install Set up JDK 17 to support SonarQube
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@samatstariongroup samatstariongroup deleted the GH285 branch December 7, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxatstariongroup lxatstariongroup lxatstariongroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samatstariongroup @lxatstariongroup