[Implement] SQ improvements

STARIONGROUP · Oct 19, 2024 · c14ce4c · c14ce4c
1 parent 8dc0fbd
commit c14ce4c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 15 deletions.
diff --git a/CDP4Common/Extensions/GuidExtensions.cs b/CDP4Common/Extensions/GuidExtensions.cs
@@ -102,7 +102,7 @@ public static Guid FromShortGuid(this string shortGuid)
         /// </returns>
         /// <remarks>
         /// A ShortGuid is a base64 encoded guid-string representation where any "/" has been replaced with a "_"
-        /// and any "+" has been replaced with a "-" (to make the string representation <see cref=".Uri" /> friendly)
+        /// and any "+" has been replaced with a "-" (to make the string representation <see cref="Uri" /> friendly)
         /// A ShortGuid Array is a string that starts with "[", ends with "]" and contains a number of ShortGuid separated by a ";"
         /// </remarks>
         /// <exception cref="ArgumentException">

diff --git a/CDP4Common/Extensions/IRuleVerificationExtensions.cs b/CDP4Common/Extensions/IRuleVerificationExtensions.cs
@@ -36,7 +36,6 @@ public static class IRuleVerificationExtensions
         /// <summary>
         /// Returns a human readable string of a <see cref="Thing"/> to identify a <see cref="Thing"/> in RuleVerification text
         /// </summary>
-        /// <typeparam name="T">Any type</typeparam>
         /// <param name="value">The <see cref="IRuleVerification"/> to check</param>
         /// <param name="thing">The <see cref="Thing"/></param>
         /// <returns>The human readable identifier</returns>

diff --git a/CDP4Common/Helpers/NestedElementTreeGenerator.cs b/CDP4Common/Helpers/NestedElementTreeGenerator.cs
@@ -691,7 +691,7 @@ private NestedParameter CreatedNestedParameter(ParameterOrOverrideBase parameter
             {
                 actualValue = valueSet.ActualValue == null ? "-" : valueSet.ActualValue[componentIndex];
             }
-            catch (ArgumentOutOfRangeException e)
+            catch (ArgumentOutOfRangeException)
             {
                 actualValue = "-";
             }
@@ -702,7 +702,7 @@ private NestedParameter CreatedNestedParameter(ParameterOrOverrideBase parameter
             {
                 formula = valueSet.Formula == null ? "-" : valueSet.Formula[componentIndex];
             }
-            catch (Exception e)
+            catch (Exception)
             {
                 formula = "-";
             }
@@ -754,7 +754,7 @@ private NestedParameter CreateNestedParameter(ParameterSubscription subscription
             {
                 actualValue = valueSet.ActualValue == null ? "-" : valueSet.ActualValue[componentIndex];
             }
-            catch (ArgumentOutOfRangeException e)
+            catch (ArgumentOutOfRangeException)
             {
                 actualValue = "-";
             }

diff --git a/CDP4Common/Types/ValueArray.cs b/CDP4Common/Types/ValueArray.cs
@@ -68,7 +68,7 @@ public ValueArray(Thing container)
         /// Initializes a new instance of the <see cref="ValueArray{T}"/> class.
         /// </summary>
         /// <param name="initializationCollection">
-        /// Collection to initialize this <see cref="Collection{T}"/>.
+        /// Collection to initialize this <see cref="IEnumerable{T}"/>.
         /// </param>
         public ValueArray(IEnumerable<T> initializationCollection)
         {
@@ -79,7 +79,7 @@ public ValueArray(IEnumerable<T> initializationCollection)
         /// Initializes a new instance of the <see cref="ValueArray{T}"/> class.
         /// </summary>
         /// <param name="initializationCollection">
-        /// Collection to initialize this <see cref="Collection{T}"/>.
+        /// Collection to initialize this <see cref="IEnumerable{T}"/>.
         /// </param>
         /// <param name="container">The container of this <see cref="ValueArray{T}"/></param>
         public ValueArray(IEnumerable<T> initializationCollection, Thing container)

diff --git a/CDP4ServicesDal/CdpServicesDal.cs b/CDP4ServicesDal/CdpServicesDal.cs
@@ -44,6 +44,7 @@ namespace CDP4ServicesDal
     using CDP4Common.CommonData;
     using CDP4Common.DTO;
     using CDP4Common.Extensions;
+
     using CDP4DalCommon.Tasks;
 
     using CDP4Dal;
@@ -62,7 +63,6 @@ namespace CDP4ServicesDal
     using EngineeringModelSetup = CDP4Common.SiteDirectoryData.EngineeringModelSetup;
     using Thing = CDP4Common.DTO.Thing;
     using UriExtensions = CDP4Dal.UriExtensions;
-    using System.Runtime.InteropServices;
 
     /// <summary>
     /// The purpose of the <see cref="CdpServicesDal"/> is to provide the Data Access Layer for CDP4 ECSS-E-TM-10-25
@@ -222,9 +222,7 @@ public override async Task<IEnumerable<Thing>> Write(OperationContainer operatio
 
                     deserializationWatch.Stop();
 
-                    Guid iterationId;
-
-                    if (this.TryExtractIterationIdfromUri(httpResponseMessage.RequestMessage.RequestUri, out iterationId))
+                    if (this.TryExtractIterationIdfromUri(httpResponseMessage.RequestMessage.RequestUri, out var iterationId))
                     {
                         this.SetIterationContainer(result, iterationId);
                     }
@@ -1023,10 +1021,6 @@ public override async Task<IEnumerable<Thing>> CherryPick(Guid engineeringModelI
         /// <param name="injectedClient">
         /// The injected <see cref="HttpClient"/> that will be used to created the returned <see cref="HttpClient"/>
         /// </param>
-        /// <param name="trustAllSSL">
-        /// The value that indicates whether all SSL certificates are trusted or not. If false, then only properly signed
-        /// SSL certs are accepted
-        /// </param>
         /// <returns>
         /// An instance of <see cref="HttpClient"/> with the DefaultRequestHeaders set
         /// </returns>