oxidd_zdd_adapter: Fix ithvar/nithvar
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trailing commas are invalid in standard JSON
These should return the Boolean function, not the singleton set
|
Indeed, this would probably first become a noticeable issue when ZDDs are added to the QBF benchmark (#78). |
SSoelvsten
approved these changes
Oct 2, 2024
SSoelvsten
added
🔌 adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that I probably have implemented these methods wrongly. They should return the Boolean function
x_i, not the singleton set{x_i}, right? (So far I could not find any benchmark/input combination where the change would make a difference, most benchmarks do not seem to use these methods anyway …)This PR also includes two minor improvements/fixes to the CNF benchmark.