♻️ 403 simplify global exception handling (#407)

SSWConsulting · Oct 29, 2024 · df198fb · df198fb
1 parent af27df3
commit df198fb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/src/Application/Features/Teams/Commands/ExecuteMission/ExecuteMissionCommand.cs b/src/Application/Features/Teams/Commands/ExecuteMission/ExecuteMissionCommand.cs
@@ -23,7 +23,10 @@ public async Task<ErrorOr<Success>> Handle(ExecuteMissionCommand request, Cancel
         if (team is null)
             return TeamErrors.NotFound;
 
-        team.ExecuteMission(request.Description);
+        var result = team.ExecuteMission(request.Description);
+        if (result.IsError)
+            return result;
+
         await dbContext.SaveChangesAsync(cancellationToken);
 
         return new Success();

diff --git a/src/WebApi/Filters/DefaultExceptionHandlerExtensions.cs b/src/WebApi/Filters/DefaultExceptionHandlerExtensions.cs
diff --git a/src/WebApi/Program.cs b/src/WebApi/Program.cs
@@ -4,12 +4,12 @@
 using SSW.CleanArchitecture.WebApi;
 using SSW.CleanArchitecture.WebApi.Extensions;
 using SSW.CleanArchitecture.WebApi.Features;
-using SSW.CleanArchitecture.WebApi.Filters;
 using SSW.CleanArchitecture.WebApi.HealthChecks;
 
 var builder = WebApplication.CreateBuilder(args);
 
 builder.AddServiceDefaults();
+builder.Services.AddProblemDetails();
 
 builder.Services.AddWebApi(builder.Configuration);
 builder.Services.AddApplication();
@@ -31,16 +31,14 @@
 app.MapOpenApi();
 app.MapScalarApiReference(options => options.WithDefaultHttpClient(ScalarTarget.CSharp, ScalarClient.HttpClient));
 app.UseHealthChecks();
-
 app.UseHttpsRedirection();
 app.UseStaticFiles();
 
-app.UseDefaultExceptionHandler();
 app.MapHeroEndpoints();
 app.MapTeamEndpoints();
+app.UseEventualConsistencyMiddleware();
 
 app.MapDefaultEndpoints();
-
-app.UseEventualConsistencyMiddleware();
+app.UseExceptionHandler();
 
 app.Run();