Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: post 작성페이지 레이아웃 변경, 로딩화면 구현 #49

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

5nxtnxtnxt
Copy link
Contributor

Describe your changes

  • figma참고 스타일 변경
  • 이미지 업로드 오래걸려서 로딩화면 추가
  • drag & drop은 미구현

Photo

잘 보면 waiting...보임 끝나면 /feed로 이동

Issue number and link

change design
redirect after postAPI success
이미지 업로드가 끝날때까지 보여줄 로딩화면 구현
@5nxtnxtnxt 5nxtnxtnxt added enhancement New feature design About CSS refactor Rewrite existing source code labels Jul 15, 2024
@5nxtnxtnxt 5nxtnxtnxt requested a review from esthel7 July 15, 2024 16:39
@5nxtnxtnxt 5nxtnxtnxt self-assigned this Jul 15, 2024
Copy link
Member

@esthel7 esthel7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프엔계의 지니🧞

Comment on lines +106 to +107
setPosting(false);
window.location.href = '/feed';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 window.location.href 썼었는데 next/navigationuseRouter 있거든요?? 이거 쓰면 뒤로가기도 활성화되더라구영~

Comment on lines +117 to +121
{posting && (
<div className="fixed bg-slate-500 bg-opacity-20 z-50 size-full top-0 left-0 flex items-center justify-center">
waiting...
</div>
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋ센스 굿👍

@5nxtnxtnxt 5nxtnxtnxt merged commit a14ac8b into SSOCK:main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design About CSS enhancement New feature refactor Rewrite existing source code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants