Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-10/20/2024 #86

Merged
merged 77 commits into from
Oct 20, 2024
Merged

Update-10/20/2024 #86

merged 77 commits into from
Oct 20, 2024

Conversation

VMSolidus
Copy link
Contributor

Description

Absolute shitton of bugfix PRs. Some new content too.

Aidenkrz and others added 30 commits October 15, 2024 19:05
# Description

Title
Upstream cherry pick fucked it, this fixes it.

---

<details><summary><h1>Media</h1></summary>
<p>

### Before

![image](https://github.com/user-attachments/assets/b8d3876a-2c73-44e0-b9de-9650ee5074ae)
### After

![image](https://github.com/user-attachments/assets/49859d45-c6e0-4d03-84fa-de8bcb00de11)
</p>
</details>

---

# Changelog

:cl:
- fix: Reverse engineering machine UI works again.
# Description

title

---

# Media

im lazy, imagine arachne but they arent big errors.

---

# Changelog

:cl:
- fix: Arachne no longer turn into errors when they take damage
# Description

Cocoon size is now based on the humanoids height/width, or the sprite
scale/size.
Also makes it so we aren't calling a command to change the scale.

---

<details><summary><h1>Media</h1></summary>
<p>

### Large Oni

https://github.com/user-attachments/assets/c26f6b34-39f7-437c-af86-715185855aff

### Small Felinid

https://github.com/user-attachments/assets/5a82affb-b8b7-4b79-aa39-37f5a7a2e35e

### Mouse

https://github.com/user-attachments/assets/42d7b41e-7333-4052-a1d1-698ce337706e

### Dragon

https://github.com/user-attachments/assets/210eab03-416c-4795-a384-9e502fe794a2

</p>
</details>

---

# Changelog

:cl:
- tweak: Cocoon sizing has been changed to reflect the size of the
entity inside better.
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This PR updates the Gax map, fixing some important things.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->


---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![Example Media Embed](https://example.com/thisimageisntreal.png)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Gax station: fixed arrivals being unable to dock due to meteor
shielding and translated security camera names to English.
# Description

Apparently the psionic power rolls were not including a D100 roll in the
baseline, so people were getting new psionic powers waaaaaay slower than
was intended. Also, makes late-join psions use the glimmer calculation.

# Changelog

:cl:
- tweak: Psionic Rolls should now generate larger, random amounts of
Potentia. This should make it a lot easier to obtain powers.
* Check for flavor text equality in profile.

* Fix some characters being deleted from flavor text

Sometimes the last few characters of the flavor text would get deleted.
This fixes this issue.

(cherry picked from commit 9f1d95e3353493f28d579b562de348a322312885)

# Description

This PR fixes some database issues present in The Wizmerge.

# Changelog

No changelog, this isn't player facing.

---------

Co-authored-by: Pieter-Jan Briers <[email protected]>
Co-authored-by: Evgencheg <[email protected]>
Co-authored-by: beck-thompson <[email protected]>
Co-authored-by: dffdff2423 <[email protected]>
# Description

Crawling on tables was janky, if you stood up while crawling, or laid
down while climbing, it would push you to the edge of the table and
break.

Solves #995

---

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/08aa0e22-0363-45d8-810f-c69f7a796d7c


https://github.com/user-attachments/assets/5a31df3c-f01c-4500-94fb-f4beb3c6e007

</p>
</details>

---

# Changelog

:cl:
- fix: You can properly lay down and stand up on tables now.

Co-authored-by: VMSolidus <[email protected]>
…g A Fixture (#1049)

# Description

Title
Intended to stop players from making slender men type characters with
height maxed and width at the minimum, and vice versa
The ratio can be modified via the species' prototype

Also fixes the issue of players being able to noclip because they're
fixture has no radius by setting the Height and Width to the species
default if none is provided. (technically this also fixes Urists always
being as small as possible)

Solves #865 #497
Partially resolves #995

---

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/1b3b32f1-5976-41f8-935b-7d53106e5452

</p>
</details>

---

# Changelog

:cl:
- tweak: Height and width are now constrained by each other.
- fix: Humanoids can no longer phase through walls.

---------

Signed-off-by: Aiden <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
# Description

Bluespace crystals would turn into ore when ejected from autolathe, lead
me down a rabbit hole of issues with them.

- fixes above mentioned 
- normality crystals dont appear as bluespace when inserted into lathes
anymore
- adds textures for ores and crystals (grey cuz its "normal" duh)
- fixes glimmer drain using a DIFFERENT normality crystal that was made
with chems
- the old chem version now gives new normality crystals
- add crafting recipes for bluespace parts (fixes not being able to
reverse engineer them)

Fixes #980 

---

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/4464948b-edbe-4b8b-93ad-21aae192b2aa)


</p>
</details>

---

# Changelog

:cl:
- fix: Bluespace crystals now properly eject from lathes.
- fix: Bluespace parts can be reverse engineered.

---------

Signed-off-by: Aiden <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
# Description

There were some missing meta.json entries.
# Description

This PR fixes the Singer trait, as well as the Harpy singing ability. As
a bonus, the action button is no longer hardcoded to the species.

# Changelog

:cl:
- fix: Fixed Harpy singing not opening the Midi Player.
# Description
Fixes cleaning forensics off of an object being impossible unless it has
a scent. Explained in the latest (to date) comment to #715.

Also removes some unnecessarily duplicated code and inverts an if
condition.

# Changelog
:cl:
- fix: Soap once again can be used to clean evidence off.
# Description

- Generalizes cocooning
- Allows any mob to be cocooned
- Cocoon bloodsucking moved to vampirism system
- Any blood sucker can drink from cocoons
- Vampirism no longer fails if bloodstream isn't normal blood, but gives
a pop up
- Vampirism `WebRequired` actually works in a way that makes sense
- Adds cocooning and bloodsucker to all spider mobs + Arachnids

resolves #978

---

# Changelog

:cl:
- tweak: All spiders, arachne, and arachnids can cocoon mobs, and drink
their blood.

---------

Co-authored-by: VMSolidus <[email protected]>
* fix orphaned storage grid pieces getting stuck to the cursor

* instead of denying it, update it smartly

# Description

This cherry-picks
space-wizards/space-station-14#27960
Which should fix our storage UI bugs.

Co-authored-by: Nemanja <[email protected]>
# Description

- Adjusts the "danger" status threshold in Air Alarms to 20 kPa,
resulting in "warning" status at the expected 90 kPa.
- Fixes the issue where air alarms had "danger" status at 20 kPa and
"warning" status at 21 kPa

---

# Changelog

:cl: zelezniciar
- fix: Fixes Air Alarms not entering danger/warning state when pressure
is low

---------

Co-authored-by: VMSolidus <[email protected]>
# Description

This PR adds Languages to Personal Ai devices, allowing them to act as
an interpreter for their owner. PAIs carry knowledge of all "Common"
languages(Not including anything species specific, or Rare), plus the
ability to understand(but not speak) Sign language.

# Changelog

:cl:
- add: Personal Ai devices now come loaded with knowledge of all
"Common" languages, including Sign language, allowing them to interpret
for their owner.
VMSolidus and others added 28 commits October 19, 2024 17:28
# Description

Closes #1076

This fixes the "Steal The HoS's weapon" objective by first making it a
SINGLE objective that allows to stealing any of the HoS Weapons,
regardless of which one was selected. It also toggles on the
"VerifyMapExistence" setting for this objective, so that it will
correctly not generate if the station's Head of Security either isn't
present, or simply chose not to take an antique weapon to the station(I
don't know why they would do this, but it's an option).

# Changelog

:cl:
- fix: Fixed the "Steal The Head of Security's Weapon" so that it is now
a single objective that counts for any anique weapon chosen by the Head
of Security. The objective will also once again correctly not generate
if there are no valid items for it on the station.
# Description

Spiritual successor to an old unintended interaction in Delta V, where
LP ops would spawn with uplinks. Except instead of having objectives its
just an uplink with 20TC.

Why? Because it turns LP Ops from a simple nuisance into a potential
threat that can send support on station for you, and makes taking a trip
to the outpost to cash in some TC a very viable strategy. Salvage might
be more inclined to raid them too, so thats gonna be fun.

# Changelog

:cl: Mocho
- add: Added an uplink with 20TC for all Listening Post Operatives
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This PR Port the following PRs:
space-wizards/space-station-14#28085 and
DeltaV-Station/Delta-v#1678

This adds a simple job whitelist system, DB Migration correctly done,
tested and working so far.
Why now? i need it.

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Job WhiteList
- [x] Working with current RequirementSystem
- [x] DeltaV - Job Whitelist Panel Port

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/599b9018-aabe-4e5e-be86-dd2fd462c22c)

![image](https://github.com/user-attachments/assets/3eb5cf1e-b27d-40f7-b747-53fb298b6ff6)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Job Whitelist!
Unhand me, fiend

# Description

Literally all of Wizden's "Wielding Quality Of Life" improvements.

Fixes #1074
Fixes #1073

Cherry-picks the following PRs: 
space-wizards/space-station-14#26970
space-wizards/space-station-14#27973
space-wizards/space-station-14#27975
space-wizards/space-station-14#28438
space-wizards/space-station-14#27975
space-wizards/space-station-14#28002
space-wizards/space-station-14#28161

# Changelog

:cl:
- fix: Ported literally all of Wizden's Wielding Quality Of Life
improvements.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: RiceMar1244 <[email protected]>
Co-authored-by: DrSmugleaf <[email protected]>
Co-authored-by: WarMechanic <[email protected]>
Co-authored-by: Errant <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
# Description

Fixes #1085 by making it so that being in a MapAtmosphere outright
bypasses the check for "No talking in space!"

# TODO

Don't merge this without testing it, and I haven't tested it yet.

# Changelog

:cl:
- add: Being in an Atmosphere(such as Planets like Glacier & Nukieworld)
bypasses the limitation of "NO TALKING IN SPACE"
# Description
Resolves #1104


# Changelog
N/A

Signed-off-by: Mnemotechnican <[email protected]>
# Description

Introduced a generic radial selector menu. Switched
shortconstructionsystem from it's own BUI to radial selector.

# Changelog

no cl no fun (no changelog for players)

---------

Signed-off-by: Remuchi <[email protected]>
# Description

Fixes #1107
A pretty simple single-line fix that makes Breath of Life have its
correct text popup.

# Changelog

:cl:
- fix: Breath of Life now correctly displays its esoteric text popup if
the right conditions are met.
# Description

Port Shadowkin from Parkstation:
Simple-Station/Parkstation#42

---

# TODO

- [x] Specie Base
- [x] Mar Language / Empathy
- [x] Shadowkin Powers
- [x] Tiny TODO Application
- [x] Specie .yml fix
- [x] Sounds Mono Fix
- [x] EtherealLight
- [x] ethereal goggles
- [x] Shadowkin restraints
- [x] Bluespace Crystal (Kicks Ethernal Ent back to realspace)

---

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/47b45499-4c5d-4513-a48d-a291f27c76a6)

![image](https://github.com/user-attachments/assets/40ff7a72-a0a6-498b-9391-731603c8a3ef)

![image](https://github.com/user-attachments/assets/a1fed9d4-5406-4a57-9cb6-419795eead17)

</p>
</details>

---

# Changelog

:cl:
- add: Added a new species, Shadowkin!

---------

Signed-off-by: FoxxoTrystan <[email protected]>
Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
# Description

Fixes #1099

# Changelog

:cl:
- fix: Removed latejoin spawners from the Salvage Pathfinder.
# Description

Fixes #1103
This PR removes the default saxophone and acoustic guitar that the
Musician spawns with. Instead the Musician now has a selection of 3 free
picks of *almost* any instrument in the game. The only instruments not
included in his list are the Supersynth, DAW, and admeme items such as
the "Musical Lung" and "Fingerless Frets". There's a few instruments
leftover for the Clown that will be given to the clown in his own
separate PR.

To make sure the musicians can also take large instruments, this PR also
takes a feature from Frontier, that of "InstrumentFlatpacks", and adds
them to the musician loadouts. So Musicians can take for instance a
Minimoog flatpack if they so desire.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/8b79e960-440f-4f7e-9b9a-bc56d30c104a)

</p>
</details>

# Changelog

:cl:
- add: Musicians can now select for free, any 3 instruments in the game
with their loadout. This now includes things like Piano flatpacks. The
only instruments not included are the Sypersynth, DAW, and "Admeme
Instruments".
- remove: Musicians no longer spawn with a Saxophone and Acoustic guitar
by default. You pick which instruments you spawn with in your loadouts
now.
# Description

Part of our Maintainer meeting where we decided we wished to go
"Completely all-out" with the "Science Cult" side of Epistemics. Next
up, extremely fancy white robes. This PR localizes the various jobs in
Epistemics to follow the "Science Cult" theme. Research Assistant became
Novice, Scientist became Acolyte, Senior Researcher became Mystic, and
Roboticist became Golemancer.

So now the Epistemics roles are:
Novice, Acolyte, Mystic, Golemancer, Chaplain, Psionic Mantis,
Cataloguer, and Mystagogue.


![image](https://github.com/user-attachments/assets/4b2e0a26-5e6a-4dab-ae22-2d2144da8013)

# Changelog

:cl:
- add: Added localizations for all Epistemics jobs.
This reverts commit 9ddd967.

Introduced a game crashing bug.
# Description

Gax was missing a single LV cable, making it so that the Captain's
office could be crowbarred into.


![image](https://github.com/user-attachments/assets/0718e64a-ff74-4e8e-9596-61636fd4bc70)

# Changelog

:cl:
- fix: Fixed the Captain's Office on Gax Station missing an LV cable
that would power its doors.
# Description

I HAVE VERIFIED WITH INGAME TESTING THAT THIS WORKS.
Fixes #684 

# Changelog

:cl:
- fix: Fixed prisoner not spawning in the Prison if the Arrivals station
is enabled.
Copy link
Contributor

RSI Diff Bot; head commit 19860ff merging into 5a7341b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Back/etherealteleporter.rsi

State Old New Status
equipped-BACKPACK Added
icon Added

Resources/Textures/Clothing/Eyes/Glasses/etherealgoogles.rsi

State Old New Status
equipped-EYES Added
icon Added
inhand-left Added
inhand-right Added

@VMSolidus VMSolidus merged commit fe30609 into master Oct 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants