Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-Years-Update #123

Merged
merged 34 commits into from
Jan 2, 2025
Merged

New-Years-Update #123

merged 34 commits into from
Jan 2, 2025

Conversation

VMSolidus
Copy link
Contributor

Happy new years! This update includes the
"Wizmerge for AI", as well as "Psionic Refactor Version 3". I look forwards to getting y'all a shitton of crazy new psionics content for 2025 featuring this new system.

VMSolidus and others added 30 commits December 28, 2024 20:51
# Description

This update comes courtesy of the SiN Mapping Team.

- Added job roles Courier, Robotics
- Did small edits to every department.
- Made escape pod area better.
- New arrivals dock area. (Including Sec checkpoint)
- Fixed multiple bugs
- Reworked a lot of medical
- Moved Cryogenics.
- New station beacons.
- Removed ID computers from all command rooms except HOP
- All maints space windows buffed.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/038eec91-6900-4f33-8e0b-ee4167a8b770)


![image](https://github.com/user-attachments/assets/9670b1ad-4917-4ee5-b99a-a1f819c80f14)

</p>
</details>

# Changelog

:cl: SiN Mapping Team
- add: Another big update for Saltern

Co-authored-by: sleepyyapril <[email protected]>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

There are a _lot_ of issues surrounding Europa, which include, but the
big two are:
- How many complaints I'm receiving about it in general.
- Engineering issues, including a lack of an alternative beyond an SM
(supposedly)
- Lacking a cryosleep area.
- Distro air and waste are connected together.
- More here
Simple-Station/Einstein-Engines#1379 (comment)

Is there a way we can add people to review maps specifically? I'm not a
mapper, but the last few maps that have gotten through have been _bad_
at the start.

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- remove: *Temporarily* removed Europa from map pool, pending some
refurbishing.
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This PR compleatly rework shadowkins, slightly been forced this makes
shadowkins more "psionic creature" then anything else.
This is a WIP, but in general this PR make Shadowkin "Psionic" and fall
under the same rule.

RIP Shadowkin for me but ye.

CHANGES TO SHADOWKINS:
Shadowkins now follow the laws of psionic, they will always spawn with
DarkSwapPower but can generate others power, they do not spawn with
Shadeskip by default anymore, Mana has been lower from 250 to 200; they
can now pick normal psionic jobs.

Changes to DarkSwap:
DarkSwap cost 30 Mana and will raise glimmer on use, its will drain 1
Mana/Sec, will eject the user when mana is fully drained.
DarkSwap is now a random roll.

Changes to Psionics:
Added the Mana Alert for all psionics

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Psionic Mana Alert
- [x] DarkSwap Rework
- [x] Remove Unique Shadowkin Psionic Changes
- [x] Import bugs fixes/QOL changes.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

N/A

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- tweak: Shadowkins has returned and has been reworked.
- add: DarkSwap is now in the Psionic Power Pool.
- tweak: Psionics can now see their mana pools.

---------

Signed-off-by: FoxxoTrystan <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
# Description

Simple-Station/Parkstation-Friendly-Chainsaw#2
space-wizards/space-station-14#21352

---

<details><summary><h1>Media</h1></summary>
<p>

<!--
https://github.com/user-attachments/assets/701512ce-1bf2-4020-a2eb-ba1e35b18669
-->


https://github.com/user-attachments/assets/d01f01b9-dae7-4d05-91db-ac6e3de30e9f

</p>
</details>

---

# Changelog

:cl:
- tweak: Added back support for the action bar to have "loadouts" or
quick layouts of actions (man, how many things are called loadouts?)
# Description

Arrivals spawns have been limited to only the massive cryogenics bay,
and impassable barriers have been added that block access to the deeper
parts of Terminal. I've also modified the admeme items that were in
displays so that they are now fake items that can't actually be used by
players even if they SOMEHOW smash their way in and defeat the turrets.
I have photo evidence of people doing this.

Just in case, I also made arrivals a ProtectedGrid.

# Changelog

:cl:
- tweak: Tweaked arrivals to reduce the playable area, and some
concessions have been made to prevent access to admeme items that were
on display. These changes are pending a later update where we port
Arrivals Job Spawns.
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Long story short, cargo and command abuses the new reverse-engineered
suits and warning them as admins about it is getting quite tiring. So I
decided to put my hand to the craft and comment them out for now, until
a better way for them to be gotten is made.

I have also taken this opportunity to fix some of the longstanding
issues with cargo I have had, such as there missing sec masks in the
riot crate or there not being a way to get the swat items.

While I am still missing the properly developed versions with space
proofing and minor cold/head protection, the old non ARCS riot suit will
do for now.

This PR fixes
Simple-Station/Einstein-Engines#1376

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Remove problematic items from cargo
- [x] Add proper swat crate

Opt:
- [x] Make proper swat set (soon:tm:)
- [x] Adjust the armor values to fit better (can be delayed)

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

I ain't got nothing chief.

</p>
</details>

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added swat suit
- add: Added swat crate
- add: Added new crate category for secure reinforced crates
- tweak: Tweaked security supplies and crates
- tweak: Tweaked the price of Cybersun's tacsuits because apparently
they weren't charging enough to properly scam salvage techs.
- tweak: Tweaked `StructuralMetallicStrong` structural protection from
10 to 80

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
# Description

THESE GUYS CAN AND DID SOLO ENTIRE STATIONS, WHAT THE HELL?

# Changelog

:cl:
- tweak: NERFED WISPS, A LOT.
… (#1378)

# Description

Fixes #1374

I'm not sure exactly when this changed, but you now have to specify
which solution you want to inject.

Also inject on hit defaults to ignoring clothing, so I removed the
redundant set.
---

# Changelog


:cl:
- fix: Fixed mindbreaker and soulbreaker cartridges not injecting their
solutions.

Co-authored-by: sleepyyapril <[email protected]>
Ports Goob-Station/Suspicion-on-Space-Station#47

Thanks Goob for helping out. 

Co-authored-by: Icepick <[email protected]>

# Description

By request from OldDanceJacket and the SiN Mapping Team

<details><summary><h1>Media</h1></summary>
<p>



</p>
</details>

# Changelog

:cl:
- add: Ported several metric tons of mapping assets from Nuclear14

Co-authored-by: Aiden <[email protected]>
Co-authored-by: Icepick <[email protected]>
Lots of stuff. Also moved everything I could to the _Shitmed namespace
as I do in Goob. Will make future ports way faster

# Changelog
:cl: Mocho
- add: Added some fun organs and other thingies, check out the Goob PRs
if you want more details.
- fix: Fixed tons of issues with shitmed. Too many for the changelog in
fact.
# Description

I broke some things

# Changelog

:cl: Mocho
- fix: Fixed heights/widths being broken due to the shitmed patch.
# Description

They say Rome wasn't built in a day, well this entire PR was coded in a
single 6 hour Adderall binge. This PR represents the next big leap in
code capability for the PsionicSystem, completely reworking how Psionic
Powers are added and removed, such that like the TraitSystem, they
utilize modular functions governing how they work. Instead of there
being only 5 different hardcoded things that Psi Powers can do, there is
now a library containing 21 different modular functions, which are
slotted as desired into the power prototypes.

Additionally, a significant improvement in the logical flow of this is
that since each power is responsible for its own "removal codepath",
it's now possible to remove individual powers from a character, as
opposed to always needing to wipe the slate clean entirely.

I'm not going to add any new powers in this PR, nor am I touching the
code for the Psionic Actions themselves, that'll come in Part 2, in
which I refactor the Psionic-Actions so that they also operate on
similar stacks of modular functions.

This PR also makes extensive refactors to the PsionicPowerPrototype, as
well as PsionicAbilitiesSystem, so that it has all new hooks and
datafields for other systems to be able to modify a psion. It is now
entirely feasible to create unique "Types" of Psions, with their own
distinct power lists. It's also now possible to create "Tech Trees" of
powers, by setting up powers such that they write to and modify the
personalized pool of available powers to generate. For example,
Xenoglossy and Psychognomy are now dependent on Telepathy, and simply
won't appear in the list of available powers if a Psion doesn't first
have Telepathy.

# Changelog

:cl:
- add: Psionic Refactor V3 is here! No new powers are added in this
update, but the options for creating new powers has been SIGNIFICANTLY
EXPANDED.
- add: Xenoglossy and Psychognomy now can only be rolled if you first
have the Telepathy power.
- add: Breath of Life can now only be rolled if you first have the
Healing Word power
- add: Pyrokinesis and Summon Imp now require the Pyroknetic Flare power
- add: All new Psychognomy descriptors for many pre-existing powers.
Have fun being unintentionally screamed at telepathically by someone
with the POWER OVERWHELMING trait.
# Description

The slider would jump around to fix the constraints because a division
symbol was mistakenly replaced with a multiplication symbol, this fixes
that.

---

<details><summary><h1>Media</h1></summary>
<p>


![edf53e72db6e17d97df08940f04e72d7](https://github.com/user-attachments/assets/b4ebcca5-e56b-41ab-8200-a2235d9b6f7c)

</p>
</details>

---

# Changelog

:cl:
- fix: The width slider in the profile editor view now moves correctly
regarding the height slider.

Co-authored-by: sleepyyapril <[email protected]>
# Description

Cherry picks
space-wizards/space-station-14#29678
Needed for emotes to not be packed tightly together, 
also need this for a future PR where I will be fixing emotes in general
◕‿◕)

---

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/bc58aee6-f615-4f6d-ad9a-793c482f3da6)

</p>
</details>

---

# Changelog
:cl:
- fix: Fixed radial menus overlapping where there's many icons.

Co-authored-by: Rinary <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Co-authored-by: sleepyyapril <[email protected]>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

the adding AI is now up to y'all because i'm not touching loadout code
for name datasets, but it shouldn't be too bad from here

---------

Signed-off-by: sleepyyapril <[email protected]>
Signed-off-by: SolStar <[email protected]>
Signed-off-by: deltanedas <[email protected]>
Co-authored-by: themias <[email protected]>
Co-authored-by: Verm <[email protected]>
Co-authored-by: DrSmugleaf <[email protected]>
Co-authored-by: Sphiral <[email protected]>
Co-authored-by: Ed <[email protected]>
Co-authored-by: Mr. 27 <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Co-authored-by: Alzore <[email protected]>
Co-authored-by: ravage <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: Intoxicating-Innocence <[email protected]>
Co-authored-by: Saphire <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Co-authored-by: Errant <[email protected]>
Co-authored-by: Tayrtahn <[email protected]>
Co-authored-by: CaasGit <[email protected]>
Co-authored-by: BramvanZijp <[email protected]>
Co-authored-by: Boaz1111 <[email protected]>
Co-authored-by: NakataRin <[email protected]>
Co-authored-by: Kara <[email protected]>
Co-authored-by: Plykiya <[email protected]>
Co-authored-by: SlamBamActionman <[email protected]>
Co-authored-by: Doomsdrayk <[email protected]>
Co-authored-by: Brandon Hu <[email protected]>
Co-authored-by: SlamBamActionman <[email protected]>
Co-authored-by: ElectroJr <[email protected]>
Co-authored-by: Pieter-Jan Briers <[email protected]>
Co-authored-by: DrSmugleaf <[email protected]>
Co-authored-by: Julian Giebel <[email protected]>
Co-authored-by: nikthechampiongr <[email protected]>
Co-authored-by: Repo <[email protected]>
Co-authored-by: Chief-Engineer <[email protected]>
Co-authored-by: icekot8 <[email protected]>
Co-authored-by: AJCM-git <[email protected]>
Co-authored-by: Leon Friedrich <[email protected]>
Co-authored-by: no <[email protected]>
Co-authored-by: Tornado Tech <[email protected]>
Co-authored-by: osjarw <[email protected]>
Co-authored-by: Simon <[email protected]>
Co-authored-by: TGRCDev <[email protected]>
Co-authored-by: Milon <[email protected]>
Co-authored-by: deltanedas <[email protected]>
Co-authored-by: ShadowCommander <[email protected]>
Co-authored-by: Fildrance <[email protected]>
Co-authored-by: pa.pecherskij <[email protected]>
Co-authored-by: chavonadelal <[email protected]>
Co-authored-by: SolStar <[email protected]>
Co-authored-by: K-Dynamic <[email protected]>
Co-authored-by: lzk <[email protected]>
Co-authored-by: ArchRBX <[email protected]>
Co-authored-by: archrbx <[email protected]>
Co-authored-by: Radezolid <[email protected]>
Co-authored-by: Nemanja <[email protected]>
Co-authored-by: EmoGarbage404 <[email protected]>
Co-authored-by: MilenVolf <[email protected]>
Co-authored-by: Velcroboy <[email protected]>
Co-authored-by: Velcroboy <[email protected]>
Co-authored-by: neuPanda <[email protected]>
Co-authored-by: neuPanda <[email protected]>
Co-authored-by: Dvir <[email protected]>
Co-authored-by: Whatstone <[email protected]>
Co-authored-by: VideoKompany <[email protected]>
# Description

This PR adds three new admin commands that make use of the new
functionality available to Psionics V3. These commands are:

- addrandompsionicpower
This takes a Uid and throws it at the random psi power generation code.
Which gives it a random psi power that is available in its list of
rollable powers.

- removepsionicpower
This takes a Uid and a PsionicPower prototype ID, and attempts to remove
that power from said entity. It does nothing if the entity doesn't have
that power.

- removeallpsionicpowers
As above, but instead of needing to declare a power prototype, it just
removes ALL powers that the entity has, if any.


# Changelog

:cl:
- add: Added new admin commands AddRandomPsionicPower,
RemovePsionicPower, and RemoveAllPsionicPowers.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
@VMSolidus VMSolidus merged commit c717ca1 into master Jan 2, 2025
8 of 10 checks passed
VMSolidus pushed a commit that referenced this pull request Jan 11, 2025
Fixes the pronouns in the character preview to not show they/them
pronouns for characters that use it/its

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This just adds another condition in the fluent file that controls the
character preview text.

Essentially, characters that use it/its pronouns will go from:

"This is [character]. They are X years old."

to

"This is [character]. It is X years old."

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Probably test it, maybe.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Azzy
- fix: Fixed they/them pronouns being displayed for it/its characters in
the character preview.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants