Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding roles for members #212

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/githubsrm/administrator/errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,9 @@ class InvalidUserError(AuthenticationErrors):
def __init__(self, *args, **kwargs):
detail = kwargs.get("detail", {"error": "Invalid User!"})
super().__init__(detail=detail)


class InvalidMember(AdminErrors):
def __init__(self, *args, **kwargs):
detail = kwargs.get("detail", {"error": "Invalid Member!"})
super().__init__(detail=detail)
19 changes: 19 additions & 0 deletions server/githubsrm/administrator/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
MaintainerApprovedError,
MaintainerNotFoundError,
ProjectNotFoundError,
InvalidMember,
)


Expand Down Expand Up @@ -368,6 +369,7 @@ def admin_remove_maintainer(self, identifier: str) -> bool:

project_name = self.db.project.find_one({"_id": project_id})["project_name"]

#! Why does this exist?
project = self.db.project.find_one_and_delete(
{"_id": project_id, "maintainer_id": {"$exists": False}}
)
Expand Down Expand Up @@ -439,3 +441,20 @@ def get_maintainer_email(self, identifier: str) -> str:
return maintainer["email"]

return False

def register_member(self, doc: Dict[str, Any]):
# Using admin db to register members since members are pseudo admins :)
doc["member"] = True
self.insert_admin(doc)

def verify_member(self, doc: Dict[str, Any]):
member = self.db.admin.find_one(
{
"email": doc["email"],
"password": hashlib.sha256(doc["password"]),
"member": True,
}
)
if member:
return member
raise InvalidMember()
10 changes: 10 additions & 0 deletions server/githubsrm/administrator/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,3 +315,13 @@ def refresh(request) -> JsonResponse:
@api_view(["GET"])
def verify(request) -> JsonResponse:
return JsonResponse(data={"success": True}, status=200)


@api_view(["POST"])
def register_member(request):
...


@api_view(["POST"])
def login_member(request):
...