Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on Mac (Designed for iPad) #530

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix crash on Mac (Designed for iPad) #530

merged 2 commits into from
Dec 12, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Dec 12, 2024

Description

The app running on Mac in compatibility mode (Designed for iPad) crashes.

Changes Made

  • Exclude the call that causes the crash from running on Mac

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the bug Issue to be fix (issue and PR) - release notes section label Dec 12, 2024
@mutaben mutaben requested review from defagos, pyby and waliid December 12, 2024 10:38
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+fix-interactive-transition-crash-on-mac December 12, 2024 10:41 Inactive
@mutaben mutaben changed the title F crash from Mac (Designed for iPad) Fix crash from Mac (Designed for iPad) Dec 12, 2024
@mutaben mutaben changed the title Fix crash from Mac (Designed for iPad) Fix crash on Mac (Designed for iPad) Dec 12, 2024
@mutaben mutaben added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 6ac7399 Dec 12, 2024
2 of 4 checks passed
@mutaben mutaben deleted the fix-interactive-transition-crash-on-mac branch December 12, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

@pyby pyby Awaiting requested review from pyby

@waliid waliid Awaiting requested review from waliid

Assignees
No one assigned
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutaben @defagos @rts-devops