Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-1278 Remove view counts linked to Social View #525

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Nov 21, 2024

Description

The legacy Social View is being shutdown, and some calls won't have a successor.

View count is one of them, that's why the associated UI needs to be removed before it becomes blank.

Changes Made

  • Remove label and image associated to view count in both Storyboard and source file
  • Leave the view count enclosing stack view since it contains the details disclosure button

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben requested review from defagos and pyby November 21, 2024 12:53
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a loss! (just kiddin')

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Nov 21, 2024
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1278-social-view-removal November 21, 2024 13:21 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1278-social-view-removal November 21, 2024 13:31 Inactive
@mutaben mutaben added this pull request to the merge queue Nov 27, 2024
@mutaben mutaben removed this pull request from the merge queue due to a manual request Nov 27, 2024
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-1278-social-view-removal November 27, 2024 08:39 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-1278-social-view-removal November 27, 2024 08:39 Inactive
@mutaben mutaben added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 1d82bba Nov 27, 2024
4 of 5 checks passed
@mutaben mutaben deleted the PLAYNEXT-1278-social-view-removal branch November 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants