Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-832 Fix hero stage title and subtitle #520

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

pyby
Copy link
Member

@pyby pyby commented Oct 2, 2024

Description

In PAC, the Play CMS, editors can update media title and lead. If the media title is set to the show title, the current logic is to displays only the date. In the hero stage, it's no correct anymore, from an UX point of view.

If the media title contains the show title, Play web does not display the show title, which is correct, from an UX point of view.
Play web does not display the media published date anymore.

Changes Made

  • Add title style for MediaDescription, to avoid displaying date, in subtitles but alors in title.
  • Update areRedundant(media:, show:) like Play web implementation.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the bug Issue to be fix (issue and PR) - release notes section label Oct 2, 2024
@pyby pyby force-pushed the PLAYNEXT-832-fix-herostage branch from f7793a7 to ff2b672 Compare October 3, 2024 15:24
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-832-fix-herostage October 3, 2024 16:08 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-832-fix-herostage October 3, 2024 16:08 Inactive
@pyby pyby added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit e551c9a Oct 17, 2024
4 checks passed
@pyby pyby deleted the PLAYNEXT-832-fix-herostage branch October 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants