Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-750 Fix RTS Podcasts channel icon on CarPlay #517

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Sep 26, 2024

Description

New RTS radio channel icons were introduced in #514 .
Missing CarPlay check, the new RTS Podcasts icon is cropped on the external screen "CarPlay".
This PR proposes to fix it.

Also fixing a @svenduvoisin feedback about "RTS Option Musique" channel title, with an unexpected espace.

Changes Made

  • Like RSI Podcasts channel, use an icon pdf variant for CarPlay, with margins. The 40pts * 40pts used in RSI is now also use for RTS.
  • Fix RTS Option Musique channel title displayed in CarPlay in remote and local config.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the bug Issue to be fix (issue and PR) - release notes section label Sep 26, 2024
@pyby pyby changed the title PLAYNEXT-750 Fix RTS Podcasts channel on CarPlay PLAYNEXT-750 Fix RTS Podcasts channel icon on CarPlay Sep 26, 2024
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-750-fix-rts-carplay-icon September 28, 2024 09:54 Inactive
@pyby pyby added maintenance Code maintenance (issue and PR) - release notes section and removed maintenance Code maintenance (issue and PR) - release notes section labels Sep 28, 2024
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-750-fix-rts-carplay-icon October 3, 2024 00:02 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-750-fix-rts-carplay-icon October 3, 2024 00:03 Inactive
@pyby pyby added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit c317d60 Oct 3, 2024
4 checks passed
@pyby pyby deleted the PLAYNEXT-750-fix-rts-carplay-icon branch October 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants