-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5578 - iOS 18 Update #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the result in the simulator on iOS 18 and on an iOS 17 device. Two quick feedbacks without diving too much into the code yet:
- Restoring the small vertical space between the player bar and the bottom bar would be nicer IMHO.
- The TV program header seems broken, on iPad at least. Maybe a simulator thing, this needs to be tested on a device running the latest beta.
A suggestion also: You might want to assign the |
A few additional inputs:
|
…n depending on size class This also solves the crash that was occurring
a5def0f
to
4b33ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job done!
Co-authored-by: Pierre-Yves <[email protected]>
Description
This PR solves both issues.
Changes Made
Both issues were fixed by:
Checklist