Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYRTS-5582 Fix tab bar offset when scrolling #505

Merged
merged 1 commit into from
Jul 29, 2024
Merged

PLAYRTS-5582 Fix tab bar offset when scrolling #505

merged 1 commit into from
Jul 29, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jul 22, 2024 •
edited by pyby
Loading

Description

After changing component (#486) and making multiple fixes (#491), we introduced a regression which caused the navigation bar to scroll over the top tab bar.

This PR fixes this.

Changes Made

A category function implementation is reintroduced and the tab bar top constraint is updated accordingly.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the bug Issue to be fix (issue and PR) - release notes section label Jul 22, 2024
@mutaben mutaben requested a review from pyby July 22, 2024 08:41
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly July 22, 2024 16:01 Inactive
@pyby pyby changed the title PLAYRTS-5582 - Fix tab bar offset when scrolling PLAYRTS-5582 Fix tab bar offset when scrolling Jul 22, 2024
pyby
pyby approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@pyby pyby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@mutaben mutaben added this pull request to the merge queue Jul 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2024
@mutaben
PLAYRTS-5582 Fix tab bar offset when scrolling (#505)
cc1b01f
@mutaben mutaben removed this pull request from the merge queue due to a manual request Jul 29, 2024
@mutaben mutaben added this pull request to the merge queue Jul 29, 2024
Merged via the queue into develop with commit f8dd673 Jul 29, 2024
2 checks passed
@mutaben mutaben deleted the fix/PLAYRTS-5582-audio-pull-to-refresh-sync branch July 29, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyby pyby pyby approved these changes

Assignees
No one assigned
Labels
bug Issue to be fix (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mutaben @pyby @rts-devops