Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github pages preview iteration #457

Merged
merged 10 commits into from
Apr 7, 2024
Merged

Github pages preview iteration #457

merged 10 commits into from
Apr 7, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 7, 2024

Motivation and Context

In social network preview and Jira project tool, a link to a build is only displayed without loading javascript. Try to mitigate.

Description

  • Update fastlane to have preview image.
  • Update title for web browser history.
  • Add message if title if no javascript loaded for previews.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added dev tool Dev tool improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section labels Apr 7, 2024
@pyby pyby added this pull request to the merge queue Apr 7, 2024
Merged via the queue into develop with commit 8da6b09 Apr 7, 2024
1 check passed
@pyby pyby deleted the feature/gh-pages branch April 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev tool Dev tool improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant