Improve error message (PLAYRTS-5527) (#481)

SRGSSR · May 19, 2024 · ee59886 · ee59886
1 parent 00d36b4
commit ee59886
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 9 deletions.
diff --git a/Application/Resources/Apps/Play RSI/it.lproj/Localizable.strings b/Application/Resources/Apps/Play RSI/it.lproj/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "Il media non può essere riprodotto.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "La pagina non può essere aperta.";
 

diff --git a/Application/Resources/Apps/Play RTR/rm.lproj/Localizable.strings b/Application/Resources/Apps/Play RTR/rm.lproj/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "Il medium na po betg vegnir avert.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "La preschentaziun na po betg vegnir averta.";
 

diff --git a/Application/Resources/Apps/Play RTS/fr.lproj/Localizable.strings b/Application/Resources/Apps/Play RTS/fr.lproj/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "Le contenu ne peut être ouvert.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "La page ne peut être ouverte.";
 

diff --git a/Application/Resources/Apps/Play SRF/de.lproj/Localizable.strings b/Application/Resources/Apps/Play SRF/de.lproj/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "Der Inhalt kann nicht geöffnet werden.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "Seite konnte nicht geöffnet werden.";
 

diff --git a/Application/Resources/Apps/Play SWI/en.lproj/Localizable.strings b/Application/Resources/Apps/Play SWI/en.lproj/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "The media cannot be opened.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "The page cannot be opened.";
 

diff --git a/Application/Sources/Content/PageViewController.swift b/Application/Sources/Content/PageViewController.swift
@@ -685,9 +685,15 @@ extension PageViewController: SectionHeaderViewAction {
 
         SRGDataProvider.current!.contentPage(for: ApplicationConfiguration.shared.vendor, uid: id)
             .receive(on: DispatchQueue.main)
-            .sink { error in
-                if case .failure(let failure) = error {
-                    Banner.showError(failure as NSError)
+            .sink { result in
+                if case .failure = result {
+                    let error = NSError(
+                        domain: PlayErrorDomain,
+                        code: PlayErrorCode.notFound.rawValue,
+                        userInfo: [
+                            NSLocalizedDescriptionKey: NSLocalizedString("The page cannot be opened.", comment: "Error message when a page cannot be opened from a page section title")
+                        ])
+                    Banner.showError(error)
                 }
             } receiveValue: { contentPage in
                 let pageViewController = PageViewController.pageViewController(for: contentPage)

diff --git a/Translations/Localizable.strings b/Translations/Localizable.strings
@@ -738,7 +738,8 @@
    Error message when a media cannot be opened via Handoff, deep linking or a push notification */
 "The media cannot be opened." = "The media cannot be opened.";
 
-/* Error message when a page cannot be opened via Handoff, deep linking or a push notification
+/* Error message when a page cannot be opened from a page section title
+   Error message when a page cannot be opened via Handoff, deep linking or a push notification
    Error message when a topic cannot be opened via Handoff, deep linking or a push notification */
 "The page cannot be opened." = "The page cannot be opened.";