Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): loading media with drm #35

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(example): loading media with drm #35

merged 1 commit into from
May 8, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented May 7, 2024

Description

Media wasn't loading due to a typo in the properties for the key systems of a source.

Changes made

  • Converted licenseUrl and certificateUrl to licenseUri and certificateUri respectively.
  • Added a condition to prevent multiple loading when the route changes but a player is already active.

Media wasn't loading due to a typo in the properties for the key systems of a source.

- Converted `licenseUrl` and `certificateUrl` to `licenseUri` and `certificateUri`
  respectively.
- Added a condition to prevent multiple loading when the route changes but a player
  is already active.
@jboix jboix requested a review from amtins May 7, 2024 15:58
@jboix jboix self-assigned this May 7, 2024
Copy link

github-actions bot commented May 7, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-08 13:44 UTC

Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jboix jboix added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit c690979 May 8, 2024
2 checks passed
@jboix jboix deleted the fix/drm-loading branch May 8, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants