Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(showcase): replace native text track events #27

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Mar 20, 2024

Description

Replaces the built-in text track events, specifically cuechange, with these custom events:

  • srgssr/chapter for chapter changes.
  • srgssr/blocked-segment to identify restricted content.
  • srgssr/interval for detecting skippable content.

This change provides a more robust solution across various browsers, ensuring a more consistent user experience.

Replaces the built-in text track events, specifically `cuechange`, with these custom events:

- `srgssr/chapter` for chapter changes.
- `srgssr/blocked-segment` to identify restricted content.
- `srgssr/interval` for detecting skippable content.

This change provides a more robust solution across various browsers, ensuring a more consistent user
experience.
@jboix jboix requested a review from amtins March 20, 2024 16:48
@jboix jboix self-assigned this Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-03-21 08:36 UTC

@jboix jboix force-pushed the fix/track-showcases branch from 575e8ac to 50e2c0c Compare March 20, 2024 16:54
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 1d7e3c3 Mar 21, 2024
2 checks passed
@jboix jboix deleted the fix/track-showcases branch March 21, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants