feat(settings): add data provider host setting #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jboix
force-pushed
the
feat/data-provider-settings
branch
2 times, most recently
from
de9b2e3 to
4da6701
Compare
amtins
reviewed
Mar 13, 2024
amtins
reviewed
Mar 13, 2024
This feature enhances the demo application's configurability by allowing users to specify a custom data provider host via the settings page. This flexibility is crucial for adapting the application to different data sources and environments. Changes: - **Data Provider Host Setting:** Introduced an input field on the settings page for changing the data provider host. This setting is propagated throughout the demo, affecting the player and integration layer callbacks (for the search and list views). The new setting is saved in local storage. - Reduced specificity of the theme's input styles to simplify overriding the style. - Applied `appearance: none` to select elements. In Safari browsers this hide default browser-specific appearances, which was showing up until now.
jboix
force-pushed
the
feat/data-provider-settings
branch
from
4da6701 to
e5d25ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature enhances the demo application's configurability by allowing users to specify a custom data provider host via the settings page. This flexibility is crucial for adapting the application to different data sources and environments.
Changes made
appearance: noneto select elements. In Safari browsers this hide default browser-specific appearances, which was showing up until now.