Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(showcase): showcases for custom text tracks handling #14

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented Feb 23, 2024

Description

Introduces new showcases for integrators to benefit from the inclusion of custom text tracks in the pillarbox player (see SRGSSR/pillarbox-web/pull/207).

The showcases cover the implementation of: handling blocked segments, displaying current chapters, and managing time intervals. Code examples with ample comments have been added to provide developers with technical insight on how to integrate these features. See some screenshots below.

Blocked Segments Notification

Whenever a blocked segment is skipped, shows a notification on the bottom right of the player.

image

Currently Playing Chapter

A card with information of the currently playing chapter is displayed above the control bar.

image

Skip credits button

Once a time interval is reached, a skip button is displayed on the bottom right of the player.

image

@jboix jboix self-assigned this Feb 23, 2024
@jboix jboix requested a review from amtins February 23, 2024 12:23
Copy link

github-actions bot commented Feb 23, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-26 10:39 UTC

@jboix jboix force-pushed the chore/segments-showcase branch from aa8f2be to bc85c4f Compare February 23, 2024 15:41
@jboix jboix force-pushed the chore/segments-showcase branch 3 times, most recently from 70af08b to bb7f8b8 Compare February 23, 2024 20:48
@jboix jboix marked this pull request as ready for review February 23, 2024 20:54
@jboix jboix requested a review from amtins February 23, 2024 20:54
@jboix jboix force-pushed the chore/segments-showcase branch 2 times, most recently from 5853438 to b3eccce Compare February 26, 2024 10:08
Introduces new showcases for integrators to benefit from the inclusion of custom text
tracks in the pillarbox player (see SRGSSR/pillarbox-web#207).

The showcases cover the implementation of: handling blocked segments, displaying current
chapters, and managing time intervals. Code examples with ample comments have been added
to provide developers with technical insight on how to integrate these features.
@jboix jboix force-pushed the chore/segments-showcase branch from b3eccce to 961199e Compare February 26, 2024 10:35
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thank you!

@jboix jboix added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 5b99bfa Feb 26, 2024
2 checks passed
@jboix jboix deleted the chore/segments-showcase branch February 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants