ci: add pull request previews #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboix
force-pushed
the
chore/add-pr-preview
branch
from
6c4cf04 to
b35a81f
Compare
|
jboix
force-pushed
the
chore/add-pr-preview
branch
from
b35a81f to
80634ab
Compare
jboix
changed the title
jboix
force-pushed
the
chore/add-pr-preview
branch
from
80634ab to
41edd85
Compare
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using `rossjrw/pr-preview-action`. This new workflow enables us to review both visual and functional changes before merging. The preview functionality work in the following manner: 1. **Triggering a Preview**: Whenever a pull request is either opened, re-opened, or updated, the project undergoes a build process. The contents of the `dist` directory are copied under `pr-preview/pr-${github.ref}` located in the `gh-pages` branch. 2. **Cleaning Up**: Once a pull request is closed, the corresponding preview folder (specific to the closed pull request) is deleted. Additional workflow updates include: - The `JamesIves/github-pages-deploy-action` has been updated from version 3 to version 4. This update introduces the following configurations to this action: - `force: false`: This disables force push to the deployment branch. - `clean-exclude: pr-preview/`: This prevents the deletion of PR previews when the main branch is deployed.
jboix
force-pushed
the
chore/add-pr-preview
branch
from
41edd85 to
0b4f56f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses SRGSSR/pillarbox-web#196 by introducing pull request previews using rossjrw/pr-preview-action. This new workflow enables us to review both visual and functional changes before merging.
The preview functionality work in the following manner:
Triggering a Preview: Whenever a pull request is either opened, re-opened, or updated, the project undergoes a build process. The contents of the
distdirectory are copied underpr-preview/pr-${github.ref}located in thegh-pagesbranch.Cleaning Up: Once a pull request is closed, the corresponding preview folder (specific to the closed pull request) is deleted.
Changes made
JamesIves/github-pages-deploy-actionhas been updated from version 3 to version 4. This update introduces the following configurations to this action:force: false: This disables force push to the deployment branch.clean-exclude: pr-preview/: This prevents the deletion of PR previews when the main branch is deployed.