Skip to content

Commit

Permalink
chore: remove crossorigin attribute from video-js tag
Browse files Browse the repository at this point in the history
Removes the `crossorigin="anonymous"` attribute from the <video-js> tag because we were experiencing
issues with cross-origin media.
  • Loading branch information
jboix committed Jun 6, 2024
1 parent 80e24b9 commit 95861ce
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

<body>
<demo-dialog>
<video-js id="demo-player" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="demo-player" class="pillarbox-js" controls></video-js>
</demo-dialog>

<demo-header></demo-header>
Expand Down
2 changes: 1 addition & 1 deletion static/showcases/blocked-segment.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="showcase-content">
<h2>Detect blocked segment</h2>
<div class="video-container">
<video-js id="video-element-id" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="video-element-id" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="close-btn">Close this window</button>
Expand Down
2 changes: 1 addition & 1 deletion static/showcases/chapters.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="showcase-content">
<h2>Display Current Chapter</h2>
<div class="video-container">
<video-js id="video-element-id" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="video-element-id" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="close-btn">Close this window</button>
Expand Down
4 changes: 2 additions & 2 deletions static/showcases/multi-player.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
<h2>Multiple players</h2>

<div class="video-container">
<video-js id="main-player" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="main-player" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="toggle-player">Toggle main player</button>

<div class="video-container">
<video-js id="second-player" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="second-player" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="close-btn">Close this window</button>
Expand Down
2 changes: 1 addition & 1 deletion static/showcases/skip-credits.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<div class="showcase-content">
<h2>Skip Credits</h2>
<div class="video-container">
<video-js id="video-element-id" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="video-element-id" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="close-btn">Close this window</button>
Expand Down
2 changes: 1 addition & 1 deletion static/showcases/start-time.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<div class="showcase-content">
<h2>Start the player at a given position</h2>
<div class="video-container">
<video-js id="video-element-id" class="pillarbox-js" controls crossorigin="anonymous"></video-js>
<video-js id="video-element-id" class="pillarbox-js" controls></video-js>
</div>

<button class="showcase-btn" id="close-btn">Close this window</button>
Expand Down

0 comments on commit 95861ce

Please sign in to comment.