Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for forced subtitles #533

Merged
merged 33 commits into from
Aug 20, 2023
Merged

Add support for forced subtitles #533

merged 33 commits into from
Aug 20, 2023

Conversation

defagos
Copy link
Member

@defagos defagos commented Aug 18, 2023

Description

This PR adds support for forced subtitles.

Changes made

  • Filter forced subtitles in returned legible options.
  • Apply forced subtitles automatically when meaningful.
  • Add stream packaging documentation since proper support for forced subtitles requires proper delivery in streams themselves.
  • Update local test delivery for more consistency.
  • Make a few unit test timings more tolerant.
  • Add Apple Dolby Atmos sample stream.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • The playground has been updated (if relevant).

@defagos defagos linked an issue Aug 18, 2023 that may be closed by this pull request
8 tasks
@defagos defagos enabled auto-merge August 18, 2023 12:09
@defagos defagos requested review from StaehliJ and waliid August 18, 2023 12:09
@defagos defagos disabled auto-merge August 18, 2023 12:10
@defagos defagos force-pushed the 502-forced-subtitles-support branch from f722997 to ad674a2 Compare August 18, 2023 12:10
@defagos defagos added this pull request to the merge queue Aug 20, 2023
Merged via the queue into main with commit 9179747 Aug 20, 2023
@defagos defagos deleted the 502-forced-subtitles-support branch August 20, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forced subtitles support
2 participants