Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent item creation from non-official service endpoints #1102

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Prevent item creation from non-official service endpoints #1102

merged 3 commits into from
Dec 12, 2024

Conversation

defagos
Copy link
Member

@defagos defagos commented Dec 12, 2024

Description

This PR prevents item creation from non-official SRG SSR service endpoints.

Changes made

  • Add assertion preventing creation of custom Servers outside our demo.
  • Document the (still public) Server initializer as not available.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@defagos defagos linked an issue Dec 12, 2024 that may be closed by this pull request
Hide server initializer from a base URL #1100
Closed
1 task
@waliid waliid enabled auto-merge December 12, 2024 13:33
@waliid waliid added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit f1c5581 Dec 12, 2024
7 checks passed
@waliid waliid deleted the 1100-hide-server-initializer-from-a-base-url branch December 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waliid waliid waliid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide server initializer from a base URL
2 participants
@defagos @waliid