Basic error reporting #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
11 tasks
🌙 Available in TestFlight nightliesThe most recent state can be tested in the following builds:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR is a first attempt at implementing error management. It correctly forwards errors to the user interface but fails to play any kind of content we have for reasons explained in #106. Still the changes made in this PR are relevant and more important changes to code existing prior to this PR are required to fix the problem.
Changes made
Note that this PR breaks MP3 playback for reasons explained in #106. I had the choice between non-working error forwarding through the asset loader or broken playback, and I chose to favor error reporting as it is focus of this PR.
Checklist
mainbranch.