Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to stop the VM #4

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Avoid to stop the VM #4

merged 2 commits into from
Nov 11, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Nov 11, 2024

Description

Avoid stopping the VM, because if another PR requests it, the VM will be stopped and will no longer be running. This will cause the new PR to start a new VM, which will then be deleted by the previous PR.

Changes made

Self-explanatory.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

Deleteing without stopping is impossible
@waliid waliid merged commit add46be into main Nov 11, 2024
10 of 12 checks passed
@waliid waliid deleted the avoid-stopping-vm branch November 11, 2024 10:26
waliid added a commit that referenced this pull request Nov 19, 2024
* Avoid to stop the VM

* Stop the VM instead of deleting it

Deleteing without stopping is impossible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant