Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static DICOM test data with minimal dynamic content #1918

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

rkm
Copy link
Member

@rkm rkm commented Aug 22, 2024

Proposed Changes

Many of our integration tests depend on one or more specific DICOM files which are cached in the repo. This PR replaces them with dynamically generated content.

The next step is to enable the use of MockFileSystem where sensible so that our tests don't require so much I/O.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by the @SMI/Reviewers team

Issues

Closes #2019

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.07%. Comparing base (c00eabd) to head (56b0544).

Files Patch % Lines
...ces/Microservices/DicomTagReader/DicomTagReader.cs 0.00% 2 Missing ⚠️
...ervices/DicomTagReader/DicomTagReaderCliOptions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1918      +/-   ##
==========================================
- Coverage   64.07%   64.07%   -0.01%     
==========================================
  Files         177      177              
  Lines        6525     6527       +2     
  Branches      968      969       +1     
==========================================
+ Hits         4181     4182       +1     
- Misses       2057     2058       +1     
  Partials      287      287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace static DICOM test data with minimal dynamic content
1 participant