Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Navbar search persisting loading state #67

Merged
merged 10 commits into from
Sep 27, 2024

Conversation

ahmadgaz
Copy link
Collaborator

Resolves #66

@ahmadgaz ahmadgaz added the bug Something isn't working label Sep 27, 2024
@ahmadgaz ahmadgaz requested a review from chrehall68 September 27, 2024 00:38
@ahmadgaz ahmadgaz self-assigned this Sep 27, 2024
@ahmadgaz ahmadgaz linked an issue Sep 27, 2024 that may be closed by this pull request
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
course-scheduling-client ❌ Failed (Inspect) Sep 27, 2024 6:30am

Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this addresses the changes; if you click on a result after searching in the navbar, then the state stays as loading.

Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works now!

@chrehall68 chrehall68 merged commit 7223e7a into develop Sep 27, 2024
1 of 5 checks passed
@chrehall68 chrehall68 deleted the 66-bug-navbar-search-persisting-loading-state branch September 27, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Navbar search persisting loading state
2 participants