Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Max height for filters #65

Merged
merged 5 commits into from
Sep 27, 2024
Merged

[Bug] Max height for filters #65

merged 5 commits into from
Sep 27, 2024

Conversation

ahmadgaz
Copy link
Collaborator

Resolves #64

@ahmadgaz ahmadgaz added the bug Something isn't working label Sep 27, 2024
@ahmadgaz ahmadgaz requested a review from chrehall68 September 27, 2024 00:05
@ahmadgaz ahmadgaz self-assigned this Sep 27, 2024
@ahmadgaz ahmadgaz linked an issue Sep 27, 2024 that may be closed by this pull request
[Bug] Max height for filters sidebar #64
Closed
@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
course-scheduling-client ❌ Failed (Inspect) Sep 27, 2024 2:24am

@ahmadgaz ahmadgaz dismissed chrehall68’s stale review September 27, 2024 01:59

The merge-base changed after approval.

chrehall68
chrehall68 previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrehall68 chrehall68 self-requested a review September 27, 2024 02:02
chrehall68
chrehall68 previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahmadgaz ahmadgaz dismissed chrehall68’s stale review September 27, 2024 02:05

The merge-base changed after approval.

chrehall68
chrehall68 previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahmadgaz ahmadgaz dismissed chrehall68’s stale review September 27, 2024 02:18

The merge-base changed after approval.

@chrehall68 chrehall68 merged commit d62f251 into develop Sep 27, 2024
1 of 5 checks passed
@chrehall68 chrehall68 deleted the 64-bug-max-height-for-filters-sidebar branch September 27, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jjmaxxx Jjmaxxx Jjmaxxx approved these changes

@chrehall68 chrehall68 chrehall68 left review comments

Assignees

@ahmadgaz ahmadgaz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Max height for filters sidebar
3 participants
@ahmadgaz @Jjmaxxx @chrehall68