-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Refactor to use real backend endpoints #50
[Feature] Refactor to use real backend endpoints #50
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's eventually replace serverFetch calls with SWR. It has some useful pagination and caching features and handles loading/error states out of the box. For now this is OK.
fakeFetch
with calls toserverFetch
, which follows a similar format, but makes real requests. To do so, it references the environment variableNEXT_PUBLIC_BACKEND_URL
. When testing, I usedhttp://localhost:8000/core
since I ran the backend on port8000
on my computer.TODO
in the code and filled with temporary placeholder valuesI tested this PR with SJSUCSClub/course-scheduling-server@6dcf1e8