Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] fixed sitemap issue, fixed privacy/tos md build issue #142

Conversation

ahmadgaz
Copy link
Collaborator

Resolves #141

@ahmadgaz ahmadgaz added the improve Any enhancement label Oct 15, 2024
@ahmadgaz ahmadgaz requested a review from chrehall68 October 15, 2024 19:37
@ahmadgaz ahmadgaz self-assigned this Oct 15, 2024
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
course-scheduling-client ❌ Failed (Inspect) Oct 15, 2024 7:37pm

Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the build error when next was prefetching the TOS and privacy pages. Looks good and builds smothly

@chrehall68 chrehall68 merged commit e3178d2 into develop Oct 15, 2024
2 of 4 checks passed
@chrehall68 chrehall68 deleted the 141-improve-sitemapxml-should-include-index-of-generated-sitemaps-use-fs-to-get-tos-and-privacy-mds branch October 15, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Any enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Sitemap.xml should include index of generated sitemaps, use fs to get tos and privacy md's
2 participants