Merge pull request #103 from SJSUCSClub/102-bug-rating-distribution-n…

…umbers-are-reversed [Bug] reverse rating arrays
SJSUCSClub · Sep 30, 2024 · 9a93074 · 9a93074
2 parents 6e399dd + d745113
commit 9a93074
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/app/(main)/compare/page.tsx b/app/(main)/compare/page.tsx
@@ -210,11 +210,11 @@ export default async function Page({
               series={[
                 ...(professorStats.map((professor) => ({
                   name: professor.id,
-                  data: professor.ratingDistribution,
+                  data: professor.ratingDistribution.reverse(),
                 })) ?? []),
                 ...(courseStats.map((course) => ({
                   name: course.id,
-                  data: course.ratingDistribution,
+                  data: course.ratingDistribution.reverse(),
                 })) ?? []),
               ]}
               categories={[5, 4, 3, 2, 1]}

diff --git a/app/(main)/courses/[id]/@statistics/page.tsx b/app/(main)/courses/[id]/@statistics/page.tsx
@@ -186,7 +186,12 @@ export default async function Page({
         <Card className="p-lg max-lg:w-full lg:flex-1">
           <p className="pb-sm font-bold">Rating Distribution</p>
           <BarChart
-            series={[{ name: 'Rating Distribution', data: reviewDistribution }]}
+            series={[
+              {
+                name: 'Rating Distribution',
+                data: reviewDistribution.reverse(),
+              },
+            ]}
             categories={[5, 4, 3, 2, 1]}
           />
         </Card>

diff --git a/app/(main)/professors/[id]/@statistics/page.tsx b/app/(main)/professors/[id]/@statistics/page.tsx
@@ -194,7 +194,7 @@ export default async function Page({
             series={[
               {
                 name: 'Rating Distribution',
-                data: reviewDistribution,
+                data: reviewDistribution.reverse(),
               },
             ]}
             categories={[5, 4, 3, 2, 1]}

diff --git a/components/molecules/client/profile-btn/component.tsx b/components/molecules/client/profile-btn/component.tsx
@@ -3,7 +3,7 @@
 import { LinkBtn } from '@/components/atoms';
 import { cn } from '@/utils/cn';
 import { useSession } from '@/wrappers/session-provider';
-import { UserIcon } from '@heroicons/react/20/solid';
+import { UserCircleIcon } from '@heroicons/react/24/solid';
 
 interface Props
   extends Omit<
@@ -20,8 +20,9 @@ export const ProfileBtn: React.FC<Props> = ({ className, ...props }) => {
         {...props}
         href="/profile"
         variant="tertiary"
+        aria-label="Profile"
       >
-        <UserIcon width={20} height={20} /> Profile
+        <UserCircleIcon width={24} height={24} />{' '}
       </LinkBtn>
     );
   }

diff --git a/components/organisms/schedule/component.tsx b/components/organisms/schedule/component.tsx
@@ -27,7 +27,7 @@ export const Schedule: React.FC<Props> = (props) => (
   <LinkBtn
     variant="tertiary"
     className="rounded-lg p-0 text-inherit"
-    href={props.link}
+    href={props.title !== 'TBA' ? props.link : '#'}
   >
     <Card className="flex w-full flex-col gap-sm max-lg:p-sm lg:p-lg">
       <div className="flex max-lg:flex-col max-lg:items-center max-lg:gap-sm max-lg:p-sm lg:items-start lg:justify-between lg:gap-md">