Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some C++ compiler warnings #75

Merged
merged 3 commits into from
Nov 27, 2021
Merged

Conversation

ritwit
Copy link
Contributor

@ritwit ritwit commented Nov 20, 2021

Addresses a part of Issue #74

Warnings that are addressed by this PR:

  • -Wsign-compare
  • -Wunused-variable
  • -Wunused-but-set-variable
  • -Wmaybe-uninitialized (probably the most important)
  • -Wunused-parameter (from -Wextra)
  • -Wstrict-prototypes (enabled by setup.py but not valid for C++)

I may be able to look at other warnings too if I get time. Thanks.

@lauri-codes lauri-codes changed the base branch from master to v1.2.1 November 27, 2021 18:43
@lauri-codes lauri-codes merged commit d336445 into SINGROUP:v1.2.1 Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants