Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNU compiler warnings #74

Open
ritwit opened this issue Nov 20, 2021 · 1 comment
Open

GNU compiler warnings #74

ritwit opened this issue Nov 20, 2021 · 1 comment

Comments

@ritwit
Copy link
Contributor

ritwit commented Nov 20, 2021

This is a minor issue but worth addressing.

The GCC compiler throws many warnings when compiling the C++ extensions of Dscribe. Some of them are obvious and easy to fix. It may be a good idea to take a look at each of these warnings and ensure that they are benign.

I can submit a PR to fix some of the easy ones.

Thanks!

@lauri-codes
Copy link
Contributor

Hi @ritwit!

You're absolutely right. We have mostly ignored these warnings which is definitely not a good practice... Thank you also for your pull request: I will take a look and include it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants