Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest YJHK MKO photometry from ultracool sheet #533

Merged
merged 16 commits into from
Jul 15, 2024

Conversation

Exu-112
Copy link
Collaborator

@Exu-112 Exu-112 commented Jul 10, 2024

Short description: Ingest of the YJHK band MKO photometries from the Ultracool sheet

Link to relevant issue: Closes #525

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@Exu-112 Exu-112 requested a review from kelle July 10, 2024 21:21
@kelle
Copy link
Collaborator

kelle commented Jul 11, 2024

Looks amazing but please use the ingest_photometry function in astrodb_utils : astrodb_utils/photometry.py

Maybe keep your function but call it ingest_phot_exu or something like that.

Comment on lines +203 to +208
if total != len(uc_sheet_table) * 4:
msg = "data points tracked inconsistent with UC sheet"
logger.error(msg)
raise AstroDBError(msg)
elif DB_SAVE:
db.save_database(directory="data/")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Comment on lines 7263 to 7267
"reference": "WFAU19",
"bibcode": "noADS_WFAU19",
"doi": null,
"description": null
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bibcode should be null.
Comment: "UKIDSS DR11+ Release: http://wsa.roe.ac.uk/dr11plus_release.html"

Comment on lines 7275 to 7279
"reference": "UCS_24",
"bibcode": "noADS_UCS_24",
"doi": null,
"description": null
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should ingest any photometry with this reference.

Comment on lines 7280 to 7285
{
"reference": "usyn24",
"bibcode": "noADS_usyn24",
"doi": null,
"description": null
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should ingest anything with this reference.

Comment on lines 7269 to 7273
"reference": "Schn23b",
"bibcode": "2023AJ....166..103S",
"doi": null,
"description": null
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref=Schn23.ace9
doi = 10.3847/1538-3881/ace9bf

Comment on lines 7287 to 7314
"reference": "McMa21",
"bibcode": "2021yCat.2367....0M",
"doi": null,
"description": null
},
{
"reference": "Nowa20",
"bibcode": "2020A&A...642L...2N",
"doi": null,
"description": null
},
{
"reference": "Stol20b",
"bibcode": "2020A&A...644A..13S",
"doi": null,
"description": null
},
{
"reference": "Stol21",
"bibcode": "2021AJ....162..286S",
"doi": null,
"description": null
},
{
"reference": "Alle16b",
"bibcode": "2016PhDT.......189A",
"doi": null,
"description": null
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should have DOIs and descriptions. Did you use the ingest_publication function? You might need to setup your ADS Token.

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kelle kelle merged commit 3fe432f into SIMPLE-AstroDB:main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest YJHK MKO photometry from Ultracool Sheet
2 participants