-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest YJHK MKO photometry from ultracool sheet #533
Ingest YJHK MKO photometry from ultracool sheet #533
Conversation
Looks amazing but please use the ingest_photometry function in astrodb_utils : astrodb_utils/photometry.py Maybe keep your function but call it ingest_phot_exu or something like that. |
if total != len(uc_sheet_table) * 4: | ||
msg = "data points tracked inconsistent with UC sheet" | ||
logger.error(msg) | ||
raise AstroDBError(msg) | ||
elif DB_SAVE: | ||
db.save_database(directory="data/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
data/Publications.json
Outdated
"reference": "WFAU19", | ||
"bibcode": "noADS_WFAU19", | ||
"doi": null, | ||
"description": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bibcode should be null.
Comment: "UKIDSS DR11+ Release: http://wsa.roe.ac.uk/dr11plus_release.html"
data/Publications.json
Outdated
"reference": "UCS_24", | ||
"bibcode": "noADS_UCS_24", | ||
"doi": null, | ||
"description": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should ingest any photometry with this reference.
data/Publications.json
Outdated
{ | ||
"reference": "usyn24", | ||
"bibcode": "noADS_usyn24", | ||
"doi": null, | ||
"description": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should ingest anything with this reference.
data/Publications.json
Outdated
"reference": "Schn23b", | ||
"bibcode": "2023AJ....166..103S", | ||
"doi": null, | ||
"description": null | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref=Schn23.ace9
doi = 10.3847/1538-3881/ace9bf
data/Publications.json
Outdated
"reference": "McMa21", | ||
"bibcode": "2021yCat.2367....0M", | ||
"doi": null, | ||
"description": null | ||
}, | ||
{ | ||
"reference": "Nowa20", | ||
"bibcode": "2020A&A...642L...2N", | ||
"doi": null, | ||
"description": null | ||
}, | ||
{ | ||
"reference": "Stol20b", | ||
"bibcode": "2020A&A...644A..13S", | ||
"doi": null, | ||
"description": null | ||
}, | ||
{ | ||
"reference": "Stol21", | ||
"bibcode": "2021AJ....162..286S", | ||
"doi": null, | ||
"description": null | ||
}, | ||
{ | ||
"reference": "Alle16b", | ||
"bibcode": "2016PhDT.......189A", | ||
"doi": null, | ||
"description": null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should have DOIs and descriptions. Did you use the ingest_publication
function? You might need to setup your ADS Token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Short description: Ingest of the YJHK band MKO photometries from the Ultracool sheet
Link to relevant issue: Closes #525
For data ingests: