Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking how ingest_spectrum works using the ORM #501

Merged
merged 15 commits into from
Jul 16, 2024

Conversation

dr-rodriguez
Copy link
Collaborator

First pass at reworking how ingest_spectrum works using the ORM

Separate PR from kelle#4 to either merge separately and/or have the automated tests run.

@dr-rodriguez dr-rodriguez added the enhancement New feature or request label May 15, 2024
@dr-rodriguez dr-rodriguez self-assigned this May 15, 2024
@kelle
Copy link
Collaborator

kelle commented Jul 2, 2024

return a dictionary called flags.

  • "added": True if it's added and False if it's skipped.
  • "content": the data that was attempted to add
  • "message": string which includes information about why skipped

@dr-rodriguez dr-rodriguez marked this pull request as draft July 9, 2024 21:30
@dr-rodriguez
Copy link
Collaborator Author

I've added the return of flags and significantly cleaned up the tests.
However, I just realized that things like telescope, instrument, and mode used to be checked so we should update the validation to ensure they are present.

@dr-rodriguez dr-rodriguez marked this pull request as ready for review July 10, 2024 16:39
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Feel free to merge if you don't have time to implement them.

simple/schema.py Show resolved Hide resolved
simple/schema.py Show resolved Hide resolved
simple/utils/spectra.py Outdated Show resolved Hide resolved
simple/utils/spectra.py Outdated Show resolved Hide resolved
simple/utils/spectra.py Outdated Show resolved Hide resolved
simple/utils/spectra.py Outdated Show resolved Hide resolved
simple/utils/spectra.py Show resolved Hide resolved
simple/utils/spectra.py Outdated Show resolved Hide resolved
@dr-rodriguez dr-rodriguez merged commit 6df3d0e into SIMPLE-AstroDB:main Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants