Expect fewer failing spectra #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix IRS URLs script * modified data files
|
I can't get pytest to output the links of the broken spectra. I'm struggling with the |
6 tasks
|
This also passes the scheduled checks: https://github.com/SIMPLE-AstroDB/SIMPLE-db/actions/runs/6562378511 |
tests/scheduled_checks.py
Outdated
| @@ -62,5 +62,7 @@ def test_spectra_urls(db): | |||
| if status_code != 200 and status_code != 301: | |||
| broken_urls.append(spectrum_url) | |||
| codes.append(status_code) | |||
| assert (149 <= len(broken_urls) <= 150 | |||
| print(f"found {len(broken_urls)} broken spectra urls: {broken_urls}, {codes}") | |||
| assert (39 <= len(broken_urls) <= 40 | |||
| ), f"found {len(broken_urls)} broken spectra urls: {broken_urls}, {codes}" | |||
There was a problem hiding this comment.
We can probably remove the second instance of the print statement since the first one will always appear and the second will appear when the assertion fails (so the same line would be printed twice). Only a minor note, though.
dr-rodriguez
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a new branch to test out the fixed IRS spectra.