fix: Fixes batch url computation #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darkheir
force-pushed
the
fix/batch_url
branch
from
cf2674d to
ae69653
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 26 26
Lines 1897 1897
=======================================
Hits 1816 1816
Misses 81 81
☔ View full report in Codecov by Sentry. |
Eriln
reviewed
Nov 3, 2023
| # Without trailing slash | ||
| mocked_trigger_logs.reset_mock() | ||
| with patch.dict( | ||
| os.environ, {"INTAKE_URL": "https://fra2.app.sekoia.io/v1/intake-http"} |
There was a problem hiding this comment.
Are you sure the test is doing what you want, when testing on cli, the url generated seems incorrect :/
Eriln
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.