-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: User-Agent header in connector #89
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 95.83% 95.84%
=======================================
Files 26 26
Lines 1897 1900 +3
=======================================
+ Hits 1818 1821 +3
Misses 79 79
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this method called ?
We expect to use this as common method inside all connectors. The main goal is to add this header to requests to third party services and avoid blueprint. |
Then I think it should be made public. This way users of the SDK will know this is not an implementation detail and can use it without expecting breaking changes. A line should also be added in the changelog and a test to not break code coverage. |
CHANGELOG.md
Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.6.3] - 2023-11-07 | |||
|
|||
### Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Fixed | |
### Added |
CHANGELOG.md
Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
## [Unreleased] | |||
|
|||
## [1.6.3] - 2023-11-07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed only if you want to create a new release right now
## [1.6.3] - 2023-11-07 | |
## [1.7.0] - 2023-11-07 |
In this case you should also bump the version in the pyproject.yaml
file.
No description provided.