Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: User-Agent header in connector #89

Merged
merged 5 commits into from
Nov 8, 2023

Conversation

vg-svitla
Copy link
Contributor

No description provided.

@vg-svitla vg-svitla requested a review from squioc November 2, 2023 10:52
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67b09c0) 95.83% compared to head (9edca82) 95.84%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   95.83%   95.84%           
=======================================
  Files          26       26           
  Lines        1897     1900    +3     
=======================================
+ Hits         1818     1821    +3     
  Misses         79       79           
Files Coverage Δ
sekoia_automation/connector/__init__.py 98.40% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 2, 2023

Test Results

163 tests  +1   162 ✔️ +1   1m 28s ⏱️ -3s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 9edca82. ± Comparison against base commit 3592042.

♻️ This comment has been updated with latest results.

@squioc squioc requested a review from Darkheir November 2, 2023 14:53
squioc
squioc previously approved these changes Nov 2, 2023
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Darkheir Darkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this method called ?

@vg-svitla
Copy link
Contributor Author

Where is this method called ?

We expect to use this as common method inside all connectors. The main goal is to add this header to requests to third party services and avoid blueprint.
It is not used in sdk however we want to include this in all required connectors

@Darkheir
Copy link
Collaborator

Darkheir commented Nov 3, 2023

We expect to use this as common method inside all connectors. The main goal is to add this header to requests to third party services and avoid blueprint. It is not used in sdk however we want to include this in all required connectors

Then I think it should be made public. This way users of the SDK will know this is not an implementation detail and can use it without expecting breaking changes.

A line should also be added in the changelog and a test to not break code coverage.

CHANGELOG.md Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.6.3] - 2023-11-07

### Fixed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Fixed
### Added

CHANGELOG.md Outdated
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.6.3] - 2023-11-07
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed only if you want to create a new release right now

Suggested change
## [1.6.3] - 2023-11-07
## [1.7.0] - 2023-11-07

In this case you should also bump the version in the pyproject.yaml file.

@vg-svitla vg-svitla requested review from Darkheir and squioc November 7, 2023 13:45
@Darkheir Darkheir merged commit bfcae8a into main Nov 8, 2023
6 checks passed
@otetard otetard deleted the feature/vg_add_user_agent_header branch September 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants