-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Connectors #81
Conversation
bec5b00
to
b15ec9a
Compare
76f29db
to
49fa393
Compare
263acaa
to
d9178b6
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 95.95% 95.88% -0.08%
==========================================
Files 26 26
Lines 1831 1894 +63
==========================================
+ Hits 1757 1816 +59
- Misses 74 78 +4
☔ View full report in Codecov by Sentry. |
a895e7f
to
0365ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Could you add a line in the changelog ?
0365ff1
to
05e116e
Compare
Connectors are new objects that are close to Triggers. They are meant to replace the usecase where Triggers were used to collect and send data. The modifications to the SDK are as follows: * Modules have an optionnal connector_configuration_uuid * Modules have dedicated properties for logs_ and secrets_url on top of callback_url * Connectors use a dedicated configuration JSON file * Scripts file_generator and library_sync have been updated for connectors * Tests have been updated
05e116e
to
05badea
Compare
Connectors are a new type of objects mostly similar to Triggers.
They require modifications so that the SDK can attempt to use the new Connector-specific behaviors and fallback to the old behavior if needed
Parent task