Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Connectors #81

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

a-leonardi
Copy link
Collaborator

@a-leonardi a-leonardi commented Oct 4, 2023

Connectors are a new type of objects mostly similar to Triggers.

They require modifications so that the SDK can attempt to use the new Connector-specific behaviors and fallback to the old behavior if needed

Parent task

@a-leonardi a-leonardi linked an issue Oct 4, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Test Results

161 tests  +4   160 ✔️ +4   1m 15s ⏱️ +13s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 2c6c78b. ± Comparison against base commit a6af0ad.

♻️ This comment has been updated with latest results.

@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch from bec5b00 to b15ec9a Compare October 4, 2023 15:07
@a-leonardi a-leonardi requested a review from Darkheir October 4, 2023 15:23
@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch 3 times, most recently from 76f29db to 49fa393 Compare October 5, 2023 10:10
pyproject.toml Outdated Show resolved Hide resolved
sekoia_automation/trigger.py Outdated Show resolved Hide resolved
sekoia_automation/module.py Outdated Show resolved Hide resolved
sekoia_automation/module.py Outdated Show resolved Hide resolved
sekoia_automation/module.py Show resolved Hide resolved
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch from 263acaa to d9178b6 Compare October 6, 2023 09:50
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a6af0ad) 95.95% compared to head (2c6c78b) 95.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   95.95%   95.88%   -0.08%     
==========================================
  Files          26       26              
  Lines        1831     1894      +63     
==========================================
+ Hits         1757     1816      +59     
- Misses         74       78       +4     
Files Coverage Δ
sekoia_automation/connector/__init__.py 98.36% <100.00%> (+0.32%) ⬆️
sekoia_automation/scripts/files_generator.py 97.70% <100.00%> (+0.27%) ⬆️
sekoia_automation/scripts/sync_library.py 96.17% <100.00%> (+0.26%) ⬆️
sekoia_automation/trigger.py 98.60% <ø> (-0.03%) ⬇️
sekoia_automation/module.py 92.17% <84.61%> (-0.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-leonardi a-leonardi requested a review from Darkheir October 6, 2023 13:03
Darkheir
Darkheir previously approved these changes Oct 6, 2023
sekoia_automation/connector/__init__.py Outdated Show resolved Hide resolved
@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch 4 times, most recently from a895e7f to 0365ff1 Compare October 9, 2023 15:13
@a-leonardi a-leonardi marked this pull request as ready for review October 9, 2023 15:13
@a-leonardi a-leonardi enabled auto-merge October 9, 2023 15:13
@a-leonardi a-leonardi requested a review from Darkheir October 9, 2023 15:19
Copy link
Collaborator

@Darkheir Darkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Could you add a line in the changelog ?

@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch from 0365ff1 to 05e116e Compare October 13, 2023 12:22
Connectors are new  objects that are close to Triggers. They are meant
to replace the usecase where Triggers were used to collect and send
data.
The modifications to the SDK are as follows:
* Modules have an optionnal connector_configuration_uuid
* Modules have dedicated properties for logs_ and secrets_url on top of
  callback_url
* Connectors use a dedicated configuration JSON file
* Scripts file_generator and library_sync have been updated for
  connectors
* Tests have been updated
@a-leonardi a-leonardi force-pushed the 61/Add-support-for-Connectors branch from 05e116e to 05badea Compare October 13, 2023 12:25
@a-leonardi a-leonardi requested a review from Darkheir October 13, 2023 12:25
Darkheir
Darkheir previously approved these changes Oct 13, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@a-leonardi a-leonardi merged commit a1411f3 into main Oct 13, 2023
6 checks passed
@otetard otetard deleted the 61/Add-support-for-Connectors branch September 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for connectors
2 participants