Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store TLS related files in a writable storage #80

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Darkheir
Copy link
Collaborator

@Darkheir Darkheir commented Oct 4, 2023

The directory /symphony cannot be created from inside a docker container running with low privileges. Instead write the TLS related files under /tmp

@Darkheir Darkheir requested review from squioc and otetard October 4, 2023 11:57
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Test Results

157 tests  ±0   156 ✔️ ±0   1m 10s ⏱️ +16s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 316cc57. ± Comparison against base commit f0b5257.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f0b5257) 95.84% compared to head (316cc57) 95.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files          26       26           
  Lines        1831     1831           
=======================================
  Hits         1755     1755           
  Misses         76       76           
Files Coverage Δ
sekoia_automation/storage.py 95.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Darkheir Darkheir merged commit a6af0ad into main Oct 4, 2023
6 checks passed
@otetard otetard deleted the fix/tls_files_writable_storage branch September 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants