Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of chunk_size and set intake_url from env #77

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

lvoloshyn-sekoia
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Test Results

157 tests  ±0   156 ✔️ ±0   1m 11s ⏱️ +5s
    1 suites ±0       1 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit f030778. ± Comparison against base commit 1616964.

♻️ This comment has been updated with latest results.

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review October 2, 2023 10:24
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the job.

Just a little change to apply in the CHANGELOG.md.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Quioc <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e156c6c) 96.00% compared to head (f030778) 95.95%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   96.00%   95.95%   -0.05%     
==========================================
  Files          26       26              
  Lines        1826     1830       +4     
==========================================
+ Hits         1753     1756       +3     
- Misses         73       74       +1     
Files Coverage Δ
sekoia_automation/aio/connector.py 100.00% <ø> (ø)
sekoia_automation/connector/__init__.py 98.03% <100.00%> (ø)
sekoia_automation/module.py 93.07% <20.00%> (-1.07%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squioc squioc merged commit 0208be6 into main Oct 2, 2023
@lvoloshyn-sekoia lvoloshyn-sekoia deleted the feat/chunk_size_and_intake_url branch October 3, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants