Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Useful wrappers and helpers #67

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Useful wrappers and helpers #67

merged 12 commits into from
Sep 18, 2023

Conversation

vg-svitla
Copy link
Contributor

  1. aio helpers
  2. logging helpers

@vladyslav-huriev
Useful wrappers and helpers
529334d 
1) aio helpers
2) logging helpers
@vg-svitla vg-svitla requested review from squioc and a team July 12, 2023 13:26
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited
Loading

Test Results

157 tests  +21   156 ✔️ +21   1m 19s ⏱️ +22s
    1 suites ±  0       1 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 9c95b04. ± Comparison against base commit aa40d91.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Patch coverage: 92.55% and project coverage change: -0.53% ⚠️

Comparison is base (aa40d91) 96.52% compared to head (9c95b04) 96.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   96.52%   96.00%   -0.53%     
==========================================
  Files          17       26       +9     
  Lines        1640     1826     +186     
==========================================
+ Hits         1583     1753     +170     
- Misses         57       73      +16
Files Changed Coverage Δ
sekoia_automation/loguru/handlers.py 73.33% <73.33%> (ø)
sekoia_automation/aio/helpers/aws/client.py 81.57% <81.57%> (ø)
...oia_automation/aio/helpers/http/token_refresher.py 89.79% <89.79%> (ø)
sekoia_automation/aio/connector.py 100.00% <100.00%> (ø)
sekoia_automation/aio/helpers/files/csv.py 100.00% <100.00%> (ø)
sekoia_automation/aio/helpers/files/utils.py 100.00% <100.00%> (ø)
sekoia_automation/aio/helpers/http/http_client.py 100.00% <100.00%> (ø)
sekoia_automation/aio/helpers/http/utils.py 100.00% <100.00%> (ø)
sekoia_automation/connector/__init__.py 98.03% <100.00%> (+0.03%) ⬆️
sekoia_automation/loguru/config.py 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squioc squioc requested a review from Darkheir July 17, 2023 07:00
squioc
squioc requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.
Could you add an entry in the Unreleased part on the CHANGELOG?

pyproject.toml Outdated Show resolved Hide resolved
sekoia_automation/helpers/aio/__init__.py Outdated Show resolved Hide resolved
@vg-svitla vg-svitla requested a review from squioc August 31, 2023 12:58
squioc
squioc reviewed Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. I love the async connector.

@Darkheir Could you validate some points? Thanks

.github/workflows/ci.yml

- name: Execute Python tests
id: execute-tests
run: |
poetry run python -m pytest --junit-xml=junit.xml --cov-report term --cov-report xml:coverage.xml --cov=sekoia_automation tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the directory tests in the command line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it because of incorrect configuration between local execution and gitlab ci.
For some reason it does not resolve paths with tests on local env

.pre-commit-config.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Darkheir Do you agree to this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if it works. It will allow to run checks with the same version we will have in the CI pipeline.

sekoia_automation/aio/connector.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Darkheir
Darkheir reviewed Sep 14, 2023
View reviewed changes
.pre-commit-config.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if it works. It will allow to run checks with the same version we will have in the CI pipeline.

.pre-commit-config.yaml Show resolved Hide resolved
@squioc squioc merged commit 07b957d into main Sep 18, 2023
@otetard otetard deleted the feature/aio_helpers branch September 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squioc squioc squioc approved these changes

@Darkheir Darkheir Awaiting requested review from Darkheir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vg-svitla @squioc @Darkheir @vladyslav-huriev