Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logging improvements in generic actions #153

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Darkheir
Copy link
Collaborator

  • Add additional values to log events sent to the API
  • In Generic actions, in case of error use the message from the response if available

@Darkheir Darkheir requested review from squioc and otetard November 26, 2024 14:38
Copy link

Test Results

221 tests  ±0   220 ✅ ±0   1m 41s ⏱️ -3s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4308532. ± Comparison against base commit 822a006.

@Darkheir Darkheir merged commit d0c1479 into main Nov 26, 2024
7 checks passed
@Darkheir Darkheir deleted the feat/generic_logging_improvements branch November 26, 2024 14:49
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (822a006) to head (4308532).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   90.78%   90.80%   +0.02%     
==========================================
  Files          35       35              
  Lines        2484     2491       +7     
==========================================
+ Hits         2255     2262       +7     
  Misses        229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants