Add account validation module #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-leonardi
force-pushed
the
Add_module_validation
branch
5 times, most recently
from
b87ab5c to
b363657
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 90.62% 90.73% +0.10%
==========================================
Files 34 35 +1
Lines 2453 2482 +29
==========================================
+ Hits 2223 2252 +29
Misses 230 230 ☔ View full report in Codecov by Sentry. |
a-leonardi
force-pushed
the
Add_module_validation
branch
from
b363657 to
45e8b01
Compare
Darkheir
requested changes
Oct 3, 2024
a-leonardi
force-pushed
the
Add_module_validation
branch
from
bab1bbe to
a62517f
Compare
Darkheir
force-pushed
the
Add_module_validation
branch
2 times, most recently
from
60bdbaa to
9cee138
Compare
Darkheir
previously approved these changes
Oct 28, 2024
Added an AccountValidator class that can be registered when instaciating a module in the same way as triggers or actions This class handles the account validation process, calling an abstract validator method that the user will have to fill in himself, and sending the return value of validator to a Symphony callback endpoint
Co-authored-by: Raphaël Cohen <[email protected]>
Co-authored-by: Raphaël Cohen <[email protected]>
Darkheir
force-pushed
the
Add_module_validation
branch
from
9cee138 to
94a6993
Compare
Darkheir
force-pushed
the
Add_module_validation
branch
from
94a6993 to
00aee03
Compare
Darkheir
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an AccountValidator class that can be registered when instaciating
a module in the same way as triggers or actions
This class handles the account validation process, calling an abstract
validator method that the user will have to fill in himself, and sending
the return value of validator to a Symphony callback endpoint
Parent task: #3