chore(symphony-sdk): Update to Python 3.12 #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickV
commented
Aug 23, 2024
•
PierrickV
commented
- python 3.12
- bump sdk version to 1.14.0
Test Results176 tests ±0 174 ✅ +23 1m 16s ⏱️ -8s For more details on these failures, see this check. Results for commit f87a170. ± Comparison against base commit 326d421. ♻️ This comment has been updated with latest results. |
otetard
reviewed
Aug 23, 2024
pyproject.toml
Outdated
| @@ -29,7 +29,7 @@ classifiers = [ | |||
| sekoia-automation = 'sekoia_automation.cli:app' | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.10,<3.12" | |||
| python = ">=3.11,<3.13" | |||
There was a problem hiding this comment.
IMHO, we should keep support for 3.10. We still have some modules that are using Python 3.10:
to test on python 3.10, 3.11, 3.11
|
Closing this PR since #137 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.