Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compliance checks to SDK #128

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

lvoloshyn-sekoia
Copy link
Contributor

@lvoloshyn-sekoia lvoloshyn-sekoia commented Aug 5, 2024

https://github.com/SekoiaLab/integration/issues/156

Install this version of SDK

poetry add git+https://github.com/SEKOIA-IO/sekoia-automation-sdk.git@lv/move_compliance_check_to_sdk

To check all modules, set path to automation-modules folder:

poetry run sekoia-automation check-compliance --path=~/automation-library

To check specific module, set path to its fodlder:

poetry run sekoia-automation check-compliance --path=~/automation-library/AWS

You can omit path argument to use the current folder as a path

Copy link

github-actions bot commented Aug 5, 2024

Test Results

213 tests  +1   212 ✅ +1   1m 52s ⏱️ +5s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d5ef2e8. ± Comparison against base commit 08ee681.

♻️ This comment has been updated with latest results.

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review August 5, 2024 14:48
@lvoloshyn-sekoia lvoloshyn-sekoia force-pushed the lv/move_compliance_check_to_sdk branch from e312c37 to 29f3aad Compare August 6, 2024 07:38
@lvoloshyn-sekoia lvoloshyn-sekoia force-pushed the lv/move_compliance_check_to_sdk branch from 29f3aad to bb3dd89 Compare August 6, 2024 09:56
@lvoloshyn-sekoia lvoloshyn-sekoia requested a review from squioc August 6, 2024 10:47
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I have just a little issue with the dependencies

pyproject.toml Show resolved Hide resolved
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 67.70186% with 52 lines in your changes missing coverage. Please review.

Project coverage is 93.25%. Comparing base (08ee681) to head (d5ef2e8).

Files with missing lines Patch % Lines
sekoia_automation/scripts/check_compliance.py 68.58% 49 Missing ⚠️
sekoia_automation/cli.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   90.66%   93.25%   +2.59%     
==========================================
  Files          34       33       -1     
  Lines        2420     2165     -255     
==========================================
- Hits         2194     2019     -175     
+ Misses        226      146      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants