Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module creation script #123

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Improve module creation script #123

merged 6 commits into from
Jun 14, 2024

Conversation

lvoloshyn-sekoia
Copy link
Contributor

  1. Include empty CHANGELOG.md
  2. Get the latest version of Sekoia Automation SDK automatically

Copy link

github-actions bot commented May 29, 2024

Test Results

167 tests  ±0   166 ✅ +1   1m 21s ⏱️ -11s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌  - 1 

Results for commit db606ca. ± Comparison against base commit d8c8814.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (78f7fb1) to head (dfaf030).
Report is 10 commits behind head on main.

Current head dfaf030 differs from pull request most recent head db606ca

Please upload reports for the commit db606ca to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          27       27           
  Lines        1986     1986           
=======================================
  Hits         1906     1906           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review May 29, 2024 15:08
@lvoloshyn-sekoia lvoloshyn-sekoia requested a review from squioc May 29, 2024 15:08
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squioc squioc requested a review from Darkheir June 12, 2024 11:50
@squioc squioc merged commit 1536194 into main Jun 14, 2024
4 checks passed
@squioc squioc deleted the feat/improve_module_generator branch June 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants