Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add playbooks SPL format JSON Schema and doc for third-party playbook template contributors #2054

Merged
merged 1 commit into from
Nov 8, 2024
Merged

add playbooks SPL format JSON Schema and doc for third-party playbook template contributors #2054

merged 1 commit into from
Nov 8, 2024

Conversation

jeromefellus-sekoia
Copy link
Contributor

No description provided.

@jeromefellus-sekoia jeromefellus-sekoia marked this pull request as draft October 15, 2024 14:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Pull request was merged, preview was removed.

@jeromefellus-sekoia jeromefellus-sekoia force-pushed the playbooks-json-schema branch 6 times, most recently from c962f42 to 910dbff Compare October 15, 2024 19:29
@jeromefellus-sekoia jeromefellus-sekoia marked this pull request as ready for review October 15, 2024 19:31
squioc
squioc previously requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a little fix to apply in mkdocs.yml

mkdocs.yml Outdated Show resolved Hide resolved
@jeromefellus-sekoia jeromefellus-sekoia force-pushed the playbooks-json-schema branch 2 times, most recently from 6782b97 to 5d0935b Compare October 16, 2024 14:42
@jeromefellus-sekoia jeromefellus-sekoia requested review from rombernier and pbivic and removed request for Adamowoc October 20, 2024 13:58
@jeromefellus-sekoia jeromefellus-sekoia dismissed squioc’s stale review November 8, 2024 08:15

changes applied, thanks

@jeromefellus-sekoia jeromefellus-sekoia merged commit a771f40 into main Nov 8, 2024
1 check passed
@jeromefellus-sekoia jeromefellus-sekoia deleted the playbooks-json-schema branch November 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbivic pbivic pbivic approved these changes

@dbizeul dbizeul Awaiting requested review from dbizeul

@squioc squioc Awaiting requested review from squioc

@rombernier rombernier Awaiting requested review from rombernier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeromefellus-sekoia @squioc @pbivic