Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API keys content #1902

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Update API keys content #1902

merged 2 commits into from
Jul 25, 2024

Conversation

ka0ula
Copy link
Contributor

@ka0ula ka0ula commented Jul 17, 2024

  • Add expiration dates
  • Change roles to permissions
  • Add sections about shorter API keys

ka0ula added 2 commits July 17, 2024 10:47
@ka0ula
Update API keys
252c1e5
@ka0ula
Update manage_api_keys.md
6cc8cb5 
add length of the API key + permission-based information
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Pull request was merged, preview was removed.

@ka0ula ka0ula requested a review from gaelmuller July 17, 2024 08:56
@ka0ula
Copy link
Contributor Author

ka0ula commented Jul 17, 2024

We might want to add a section about best practices to secure API keys

@ka0ula ka0ula requested a review from julienCu July 24, 2024 08:38
@julienCu
Copy link
Contributor

close: #56784

@ka0ula ka0ula merged commit 2bb1948 into main Jul 25, 2024
1 check passed
@ka0ula ka0ula deleted the update-api-keys branch July 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienCu julienCu julienCu approved these changes

@gaelmuller gaelmuller Awaiting requested review from gaelmuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ka0ula @julienCu